opendev/gerrit
Code Issues Proposed changes

Protect against nulls in GroupMembers.getGroupMembers()

Browse Source 
Change-Id: I253b7d9e1e20bc7b0b20a9fe76eaf1f799dd2306
This commit is contained in:
Chad Horohoe
2013-02-12 10:06:40 -05:00
parent 9e1db795dd
commit ca0bdda4cd
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/account/GroupMembers.java
View File

@@ -114,7 +114,7 @@ public class GroupMembers {
for (final AccountGroupIncludeByUuid groupInclude : groupDetail.includes) { for (final AccountGroupIncludeByUuid groupInclude : groupDetail.includes) {
final AccountGroup includedGroup = final AccountGroup includedGroup =
groupCache.get(groupInclude.getIncludeUUID()); groupCache.get(groupInclude.getIncludeUUID());
if (!seen.contains(includedGroup.getGroupUUID())) { if (includedGroup != null && !seen.contains(includedGroup.getGroupUUID())) {
members.addAll(listAccounts(includedGroup.getGroupUUID(), project, seen)); members.addAll(listAccounts(includedGroup.getGroupUUID(), project, seen));
} }
} }