opendev/gerrit
Code Issues Proposed changes

Refactor vote color definitions

Browse Source 
This change renames the CSS vote color definitions to mirror the REST
API response fields and moves them into the app-theme.

Change-Id: I92f6bb901df864960db1b20cf75435a157351d32
This commit is contained in:
Kasper Nilsson
2018-04-20 10:33:14 +02:00
parent 5b903c585f
commit ca464a9fe9
5 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
polygerrit-ui/app/elements/change/gr-change-metadata/gr-change-metadata.html
View File

@@ -84,16 +84,16 @@ limitations under the License.
@apply --vote-chip-styles;
}
.max {
background-color: var(--vote-color-max);
background-color: var(--vote-color-approved);
}
.min {
background-color: var(--vote-color-min);
background-color: var(--vote-color-rejected);
}
.positive {
background-color: var(--vote-color-positive);
background-color: var(--vote-color-recommended);
}
.negative {
background-color: var(--vote-color-negative);
background-color: var(--vote-color-disliked);
}
.webLink {
display: block;

8
polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row.html
View File

@@ -65,16 +65,16 @@ limitations under the License.
}
}
gr-button.iron-selected.max {
--button-background-color: var(--vote-color-max);
--button-background-color: var(--vote-color-approved);
}
gr-button.iron-selected.positive {
--button-background-color: var(--vote-color-positive);
--button-background-color: var(--vote-color-recommended);
}
gr-button.iron-selected.min {
--button-background-color: var(--vote-color-min);
--button-background-color: var(--vote-color-rejected);
}
gr-button.iron-selected.negative {
--button-background-color: var(--vote-color-negative);
--button-background-color: var(--vote-color-disliked);
}
gr-button.iron-selected.neutral {
--button-background-color: var(--vote-color-neutral);

8
polygerrit-ui/app/elements/change/gr-message/gr-message.html
View File

@@ -144,16 +144,16 @@ limitations under the License.
padding: 0 .1em;
}
.score.negative {
background-color: var(--vote-color-negative);
background-color: var(--vote-color-disliked);
}
.score.negative.min {
background-color: var(--vote-color-min);
background-color: var(--vote-color-rejected);
}
.score.positive {
background-color: var(--vote-color-positive);
background-color: var(--vote-color-recommended);
}
.score.positive.max {
background-color: var(--vote-color-max);
background-color: var(--vote-color-approved);
}
gr-account-label {
--gr-account-label-text-style: {

6
polygerrit-ui/app/styles/app-theme.html
View File

@@ -66,6 +66,12 @@ limitations under the License.
--error-text-color: red;
--vote-color-approved: #9fcc6b;
--vote-color-recommended: #c9dfaf;
--vote-color-rejected: #f7a1ad;
--vote-color-disliked: #f7c4cb;
--vote-color-neutral: #ebf5fb;
/* Diff colors */
--diff-selection-background-color: #c7dbf9;
--light-remove-highlight-color: #fee;

6
polygerrit-ui/app/styles/gr-voting-styles.html
View File

@@ -19,12 +19,6 @@ limitations under the License.
<template>
<style>
:host {
--vote-color-max: #9fcc6b;
--vote-color-positive: #c9dfaf;
--vote-color-min: #f7a1ad;
--vote-color-negative: #f7c4cb;
--vote-color-neutral: #ebf5fb;
--vote-chip-styles: {
border: 1px solid rgba(0,0,0,.12);
border-radius: 12px;