opendev/gerrit
Code Issues Proposed changes

ReviewCommand: Let PostReview handle notifyhandling

Browse Source 
In ea3e3b7 - "Downgrade default notify for WIP reviews" default
notify handling for reviews of changes in WIP state  was fixed in
PostReviews.
However ReviewCommand explicitly sets notify to ALL if notify wasn't
specified in the call which circumvents the default notify logic
in PostReviews.

Use the default notify handling in PostReviews for calls to the
"review" ssh command if notify isn't specifed in the call.

Bug: Issue 9880
Change-Id: I63a8b4ce32835055aa7ab5f7a1ca531d9b648ee8
This commit is contained in:
Sven Selberg 2018-10-17 11:24:05 +02:00
parent 950ce2633d
commit ca58713532
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java
View File

@ -252,9 +252,6 @@ public class ReviewCommand extends SshCommand {
}
private void reviewPatchSet(PatchSet patchSet) throws Exception {
if (notify == null) {
notify = NotifyHandling.ALL;
}
ReviewInput review = new ReviewInput();
review.message = Strings.emptyToNull(changeComment);