opendev/gerrit
Code Issues Proposed changes

Add comment descripting externs

Browse Source 
Bug: Issue 7022
Change-Id: Icef8047c9faf3bd3912040a7ffe5b6fdc9a6c873
This commit is contained in:
Becky Siegel
2017-08-16 14:40:29 -07:00
parent 7bd77e4856
commit cad0bdeada
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
polygerrit-ui/app/template_test_srcs/template_test.js
View File

@@ -1,6 +1,14 @@
const fs = require('fs'); const fs = require('fs');
const twinkie = require('fried-twinkie'); const twinkie = require('fried-twinkie');
/**
* For the purposes of template type checking, externs should be added for
* anything set on the window object. Note that sub-properties of these
* declared properties are considered something separate.
*
* @todo (beckysiegel) Gerrit's class definitions should be recognized in
* closure types.
*/
const EXTERN_NAMES = [ const EXTERN_NAMES = [
'Gerrit', 'Gerrit',
'GrAnnotation', 'GrAnnotation',