opendev/gerrit
Code Issues Proposed changes

RestApi#isExpected: Use Response.SC_ enum values where possible

Browse Source 
GWT's Response class provides enum values for all the HTTP status
codes used here except 422 and 429. Use the enums where possible.

Change-Id: If0076127c477643ab3d1d73ac13de4dc01499238
This commit is contained in:
David Pursehouse
2016-08-12 12:40:46 +09:00
parent 96dd7e15e2
commit cb1c02d800
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
gerrit-gwtui/src/main/java/com/google/gerrit/client/rpc/RestApi.java
View File

@@ -89,13 +89,13 @@ public class RestApi {
public static boolean isExpected(int statusCode) { public static boolean isExpected(int statusCode) {
switch (statusCode) { switch (statusCode) {
case SC_UNAVAILABLE: case SC_UNAVAILABLE:
case 400: // Bad Request case Response.SC_BAD_REQUEST:
case 401: // Unauthorized case Response.SC_UNAUTHORIZED:
case 403: // Forbidden case Response.SC_FORBIDDEN:
case 404: // Not Found case Response.SC_NOT_FOUND:
case 405: // Method Not Allowed case Response.SC_METHOD_NOT_ALLOWED:
case 409: // Conflict case Response.SC_CONFLICT:
case 412: // Precondition Failed case Response.SC_PRECONDITION_FAILED:
case 422: // Unprocessable Entity case 422: // Unprocessable Entity
case 429: // Too Many Requests (RFC 6585) case 429: // Too Many Requests (RFC 6585)
return true; return true;