From cb21cfd12d2eaed107f3bc09ff5a965668ca61b9 Mon Sep 17 00:00:00 2001
From: David Pursehouse <dpursehouse@collab.net>
Date: Thu, 19 Sep 2019 09:51:32 +0900
Subject: [PATCH] Replace assertions of hasSize(0) with isEmpty()

Change-Id: I94b11afec7e16a4bf5b7e38238ec94faabd3e921
---
 .../com/google/gerrit/acceptance/api/change/ChangeIT.java     | 4 ++--
 .../com/google/gerrit/acceptance/api/revision/RevisionIT.java | 2 +-
 .../google/gerrit/acceptance/server/change/CommentsIT.java    | 2 +-
 .../com/google/gerrit/server/group/db/AuditLogReaderTest.java | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/javatests/com/google/gerrit/acceptance/api/change/ChangeIT.java b/javatests/com/google/gerrit/acceptance/api/change/ChangeIT.java
index b4f0e9b60a..53940a7d9e 100644
--- a/javatests/com/google/gerrit/acceptance/api/change/ChangeIT.java
+++ b/javatests/com/google/gerrit/acceptance/api/change/ChangeIT.java
@@ -2003,7 +2003,7 @@ public class ChangeIT extends AbstractDaemonTest {
     // Added reviewers not notified by default.
     PushOneCommit.Result r = createWorkInProgressChange();
     gApi.changes().id(r.getChangeId()).addReviewer(in);
-    assertThat(sender.getMessages()).hasSize(0);
+    assertThat(sender.getMessages()).isEmpty();
 
     // Default notification handling can be overridden.
     r = createWorkInProgressChange();
@@ -2017,7 +2017,7 @@ public class ChangeIT extends AbstractDaemonTest {
     // that should be ignored.
     r = createWorkInProgressChange();
     gApi.changes().id(r.getChangeId()).current().review(batchIn);
-    assertThat(sender.getMessages()).hasSize(0);
+    assertThat(sender.getMessages()).isEmpty();
 
     // Top-level notify property can force notifications when adding reviewer
     // via PostReview.
diff --git a/javatests/com/google/gerrit/acceptance/api/revision/RevisionIT.java b/javatests/com/google/gerrit/acceptance/api/revision/RevisionIT.java
index 49d9f55658..22b805191c 100644
--- a/javatests/com/google/gerrit/acceptance/api/revision/RevisionIT.java
+++ b/javatests/com/google/gerrit/acceptance/api/revision/RevisionIT.java
@@ -772,7 +772,7 @@ public class RevisionIT extends AbstractDaemonTest {
     input.notify = NotifyHandling.NONE;
     sender.clear();
     gApi.changes().id(changeId).current().cherryPick(input);
-    assertThat(sender.getMessages()).hasSize(0);
+    assertThat(sender.getMessages()).isEmpty();
 
     // Disable the notification. The user provided in the 'notifyDetails' should still be notified.
     TestAccount userToNotify = accountCreator.user2();
diff --git a/javatests/com/google/gerrit/acceptance/server/change/CommentsIT.java b/javatests/com/google/gerrit/acceptance/server/change/CommentsIT.java
index 78ad1201d4..dbd7aaa0cf 100644
--- a/javatests/com/google/gerrit/acceptance/server/change/CommentsIT.java
+++ b/javatests/com/google/gerrit/acceptance/server/change/CommentsIT.java
@@ -909,7 +909,7 @@ public class CommentsIT extends AbstractDaemonTest {
     // PS2 has comments [c6, c9].
     assertThat(getRevisionComments(changeId, ps2)).hasSize(2);
     // PS3 has no comment.
-    assertThat(getRevisionComments(changeId, ps3)).hasSize(0);
+    assertThat(getRevisionComments(changeId, ps3)).isEmpty();
     // PS4 has comments [c7, c8].
     assertThat(getRevisionComments(changeId, ps4)).hasSize(2);
 
diff --git a/javatests/com/google/gerrit/server/group/db/AuditLogReaderTest.java b/javatests/com/google/gerrit/server/group/db/AuditLogReaderTest.java
index 060079f307..a5b755e3aa 100644
--- a/javatests/com/google/gerrit/server/group/db/AuditLogReaderTest.java
+++ b/javatests/com/google/gerrit/server/group/db/AuditLogReaderTest.java
@@ -53,7 +53,7 @@ public final class AuditLogReaderTest extends AbstractGroupTest {
   @Test
   public void createGroupAsServerIdent() throws Exception {
     InternalGroup group = createGroup(1, "test-group", serverIdent, null);
-    assertThat(auditLogReader.getMembersAudit(allUsersRepo, group.getGroupUUID())).hasSize(0);
+    assertThat(auditLogReader.getMembersAudit(allUsersRepo, group.getGroupUUID())).isEmpty();
   }
 
   @Test