opendev/gerrit
Code Issues Proposed changes

Fix some typos introduced during migration

Browse Source 
Should use hideHandler instead of showHandler for mouseleave

And another typo in gr-button

Change-Id: I4d239279ce3b0828f8ff6ea519111183ea571009
This commit is contained in:
Tao Zhou
2020-08-05 13:20:44 +02:00
parent 0f2d61d6d6
commit cb682aa192
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
polygerrit-ui/app/elements/shared/gr-button/gr-button.ts
View File

@@ -73,7 +73,7 @@ export class GrButton extends LegacyElementMixin(
}
@property({
computed: 'computeAriaDisable(disabled, loading)',
computed: 'computeAriaDisabled(disabled, loading)',
reflectToAttribute: true,
type: Boolean,
})

4
polygerrit-ui/app/mixins/gr-tooltip-mixin/gr-tooltip-mixin.ts
View File

@@ -101,7 +101,7 @@ export const TooltipMixin = dedupingMixin(
@observe('hasTooltip')
_setupTooltipListeners() {
if (!this.mouseenterHandler) {
this.mouseenterHandler = () => this._handleShowTooltip();
this.mouseenterHandler = this.showHandler;
}
if (!this.hasTooltip) {
@@ -151,7 +151,7 @@ export const TooltipMixin = dedupingMixin(
this._tooltip = tooltip;
window.addEventListener('scroll', this.windowScrollHandler);
this.addEventListener('mouseleave', this.showHandler);
this.addEventListener('mouseleave', this.hideHandler);
this.addEventListener('click', this.hideHandler);
}