Add acceptance tests for listing group members

Change-Id: I5d8757d1f56754ac576043000e6977fcf907c558
Signed-off-by: Sasa Zivkov <sasa.zivkov@sap.com>

gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/AccountCreator.java

@@ -102,6 +102,11 @@ public class AccountCreator {
     }
   }
 
+  public TestAccount create(String username, String group)
+      throws OrmException, UnsupportedEncodingException, JSchException {
+    return create(username, null, username, group);
+  }
+
   private AccountExternalId.Key getEmailKey(String email) {
     return new AccountExternalId.Key(AccountExternalId.SCHEME_MAILTO, email);
   }

gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/group/AccountInfo.java

@@ -0,0 +1,21 @@
+// Copyright (C) 2013 The Android Open Source Project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package com.google.gerrit.acceptance.rest.group;
+
+public class AccountInfo {
+  public Integer _account_id;
+  public String name;
+  public String email;
+}

gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/group/ListGroupMembersIT.java

@@ -0,0 +1,137 @@
+// Copyright (C) 2013 The Android Open Source Project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package com.google.gerrit.acceptance.rest.group;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import com.google.common.base.Function;
+import com.google.common.collect.Collections2;
+import com.google.common.reflect.TypeToken;
+import com.google.gerrit.acceptance.AbstractDaemonTest;
+import com.google.gerrit.acceptance.AccountCreator;
+import com.google.gerrit.acceptance.RestResponse;
+import com.google.gerrit.acceptance.RestSession;
+import com.google.gerrit.acceptance.TestAccount;
+import com.google.gson.Gson;
+import com.google.inject.Inject;
+
+import org.apache.http.HttpStatus;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.io.IOException;
+import java.util.Collection;
+import java.util.List;
+
+import javax.annotation.Nullable;
+
+public class ListGroupMembersIT extends AbstractDaemonTest {
+
+  @Inject
+  private AccountCreator accounts;
+
+  private RestSession session;
+
+  @Before
+  public void setUp() throws Exception {
+    TestAccount admin = accounts.create("admin", "Administrators");
+    session = new RestSession(admin);
+  }
+
+  @Test
+  public void listNonExistingGroupMembers_NotFound() throws Exception {
+    assertEquals(HttpStatus.SC_NOT_FOUND,
+        session.get("/groups/non-existing/members/").getStatusCode());
+  }
+
+  @Test
+  public void listEmptyGroupMembers() throws Exception {
+    group("empty", "Administrators");
+    assertTrue(GET("/groups/empty/members/").isEmpty());
+  }
+
+  @Test
+  public void listNonEmptyGroupMembers() throws Exception {
+    assertMembers(GET("/groups/Administrators/members/"), "admin");
+
+    accounts.create("admin2", "Administrators");
+    assertMembers(GET("/groups/Administrators/members/"), "admin", "admin2");
+  }
+
+  @Test
+  public void listOneGroupMember() throws IOException {
+    assertEquals(GET_ONE("/groups/Administrators/members/admin").name,
+        "admin");
+  }
+
+  @Test
+  public void listGroupMembersRecursively() throws Exception {
+    group("gx", "Administrators");
+    accounts.create("ux", "gx");
+
+    group("gy", "Administrators");
+    accounts.create("uy", "gy");
+
+    PUT("/groups/Administrators/groups/gx");
+    PUT("/groups/gx/groups/gy");
+    assertMembers(GET("/groups/Administrators/members/?recursive"),
+        "admin", "ux", "uy");
+  }
+
+  @SuppressWarnings("serial")
+  private List<AccountInfo> GET(String endpoint) throws IOException {
+    RestResponse r = session.get(endpoint);
+    assertEquals(HttpStatus.SC_OK, r.getStatusCode());
+    return (new Gson()).fromJson(r.getReader(),
+        new TypeToken<List<AccountInfo>>() {}.getType());
+  }
+
+  @SuppressWarnings("serial")
+  private AccountInfo GET_ONE(String endpoint) throws IOException {
+    RestResponse r = session.get(endpoint);
+    assertEquals(HttpStatus.SC_OK, r.getStatusCode());
+    return (new Gson()).fromJson(r.getReader(),
+        new TypeToken<AccountInfo>() {}.getType());
+  }
+
+  private void PUT(String endpoint) throws IOException {
+    session.put(endpoint).consume();
+  }
+
+  private void group(String name, String ownerGroup)
+      throws IOException {
+    GroupInput in = new GroupInput();
+    in.owner_id = ownerGroup;
+    session.put("/groups/" + name, in).consume();
+  }
+
+  private void assertMembers(List<AccountInfo> members, String name,
+      String... names) {
+    Collection<String> memberNames = Collections2.transform(members,
+        new Function<AccountInfo, String>() {
+          @Override
+          public String apply(@Nullable AccountInfo info) {
+            return info.name;
+          }
+        });
+
+    assertTrue(memberNames.contains(name));
+    for (String n : names) {
+      assertTrue(memberNames.contains(n));
+    }
+    assertEquals(members.size(), names.length + 1);
+  }
+}