opendev/gerrit
Code Issues Proposed changes

Make the constructors of all REST root collections public

Browse Source 
This allows us to implement subclasses of these collections at Google.

Change-Id: I97490758db3ec0490137ba7feb11e2a167aa9092
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2018-06-13 10:37:52 +02:00
parent 00bef8f13d
commit cb9b96e34b
5 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/com/google/gerrit/server/plugins/PluginsCollection.java
View File

@@ -36,7 +36,7 @@ public class PluginsCollection
private final Provider<InstallPlugin> install; private final Provider<InstallPlugin> install;
@Inject @Inject
PluginsCollection( public PluginsCollection(
DynamicMap<RestView<PluginResource>> views, DynamicMap<RestView<PluginResource>> views,
PluginLoader loader, PluginLoader loader,
Provider<ListPlugins> list, Provider<ListPlugins> list,

2
java/com/google/gerrit/server/restapi/account/AccountsCollection.java
View File

@@ -50,7 +50,7 @@ public class AccountsCollection
private final CreateAccount.Factory createAccountFactory; private final CreateAccount.Factory createAccountFactory;
@Inject @Inject
AccountsCollection( public AccountsCollection(
Provider<CurrentUser> self, Provider<CurrentUser> self,
AccountResolver resolver, AccountResolver resolver,
AccountControl.Factory accountControlFactory, AccountControl.Factory accountControlFactory,

2
java/com/google/gerrit/server/restapi/change/ChangesCollection.java
View File

@@ -56,7 +56,7 @@ public class ChangesCollection
private final ProjectCache projectCache; private final ProjectCache projectCache;
@Inject @Inject
ChangesCollection( public ChangesCollection(
Provider<ReviewDb> db, Provider<ReviewDb> db,
Provider<CurrentUser> user, Provider<CurrentUser> user,
Provider<QueryChanges> queryFactory, Provider<QueryChanges> queryFactory,

2
java/com/google/gerrit/server/restapi/config/ConfigCollection.java
View File

@@ -29,7 +29,7 @@ public class ConfigCollection implements RestCollection<TopLevelResource, Config
private final DynamicMap<RestView<ConfigResource>> views; private final DynamicMap<RestView<ConfigResource>> views;
@Inject @Inject
ConfigCollection(DynamicMap<RestView<ConfigResource>> views) { public ConfigCollection(DynamicMap<RestView<ConfigResource>> views) {
this.views = views; this.views = views;
} }

2
java/com/google/gerrit/server/restapi/project/ProjectsCollection.java
View File

@@ -60,7 +60,7 @@ public class ProjectsCollection
private boolean hasQuery; private boolean hasQuery;
@Inject @Inject
ProjectsCollection( public ProjectsCollection(
DynamicMap<RestView<ProjectResource>> views, DynamicMap<RestView<ProjectResource>> views,
Provider<ListProjects> list, Provider<ListProjects> list,
Provider<QueryProjects> queryProjects, Provider<QueryProjects> queryProjects,