opendev/gerrit
Code Issues Proposed changes

gerrit-gpg: Minor cleanups

Browse Source 
Change-Id: I0c9b6f4a960f212d9a4839bf1d0b0ae7fba9c99e
This commit is contained in:
Dave Borowitz
2015-09-09 12:28:58 -04:00
parent 1912561ec1
commit cbb09f8375
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gpg/src/main/java/com/google/gerrit/gpg/PublicKeyStore.java
View File

@@ -303,7 +303,7 @@ public class PublicKeyStore implements AutoCloseable {
}
if (toWrite.size() == existing.size()) {
return;
} else if (toWrite.size() > 0) {
} else if (!toWrite.isEmpty()) {
notes.set(keyObjectId(keyId),
ins.insert(OBJ_BLOB, keysToArmored(toWrite)));
} else {

4
gerrit-gpg/src/main/java/com/google/gerrit/gpg/PushCertificateChecker.java
View File

@@ -154,8 +154,8 @@ public abstract class PushCertificateChecker {
StringBuilder err = new StringBuilder("Invalid public key ")
.append(keyToString(k))
.append(":");
for (int i = 0; i < result.getProblems().size(); i++) {
err.append('\n').append(" ").append(result.getProblems().get(i));
for (String problem : result.getProblems()) {
err.append("\n ").append(problem);
}
problems.add(err.toString());
return;