opendev/gerrit
Code Issues Proposed changes

BanCommitCommand: Do not use commons.collections

Browse Source 
Bug: Issue 3662
Change-Id: I7d6656f71fe9dea1b93a3f2fcc247104f7848f1a
This commit is contained in:
David Pursehouse 2015-11-10 23:18:41 -08:00
parent 08f1cfa977
commit cbd679e610
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-sshd/BUCK
View File

@ -20,7 +20,6 @@ java_library(
'//lib:jsch', '//lib:jsch',
'//lib/auto:auto-value', '//lib/auto:auto-value',
'//lib/commons:codec', '//lib/commons:codec',
'//lib/commons:collections',
'//lib/guice:guice', '//lib/guice:guice',
'//lib/guice:guice-assistedinject', '//lib/guice:guice-assistedinject',
'//lib/guice:guice-servlet', # SSH should not depend on servlet '//lib/guice:guice-servlet', # SSH should not depend on servlet

3
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/BanCommitCommand.java
View File

@ -28,7 +28,6 @@ import com.google.gerrit.sshd.CommandMetaData;
import com.google.gerrit.sshd.SshCommand; import com.google.gerrit.sshd.SshCommand;
import com.google.inject.Inject; import com.google.inject.Inject;
import org.apache.commons.collections.CollectionUtils;
import org.eclipse.jgit.lib.ObjectId; import org.eclipse.jgit.lib.ObjectId;
import org.kohsuke.args4j.Argument; import org.kohsuke.args4j.Argument;
import org.kohsuke.args4j.Option; import org.kohsuke.args4j.Option;
@ -77,7 +76,7 @@ public class BanCommitCommand extends SshCommand {
} }
private void printCommits(List<String> commits, String message) { private void printCommits(List<String> commits, String message) {
if (CollectionUtils.isNotEmpty(commits)) { if (commits != null && !commits.isEmpty()) {
stdout.print(message + ":\n"); stdout.print(message + ":\n");
stdout.print(Joiner.on(",\n").join(commits)); stdout.print(Joiner.on(",\n").join(commits));
stdout.print("\n\n"); stdout.print("\n\n");