Revert "Fix app size to make scrollbars visible"

This reverts commit a7b89441bd.

Reason for revert: Got a better idea for app layout, will send follow-up change.

Change-Id: I7b7c86288fb070114e76dd68701e05c539089eab

polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.html

@@ -138,7 +138,6 @@ limitations under the License.
         box-shadow: 0 1px 3px rgba(0, 0, 0, .3);
         display: block;
         margin: .25em 0 1em;
-        overflow: auto;
       }
       @media screen and (max-width: 50em) {
         .row[selected] {

polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.html

@@ -31,26 +31,17 @@ limitations under the License.
     <style>
       :host {
         background-color: var(--view-background-color);
-        display: flex;
+        display: block;
-        flex-direction: column;
-        height: 100%;
       }
-      .titleHeader,
+      header,
-      .patchRangeHeader {
+      .subHeader {
         align-items: center;
         display: flex;
         justify-content: space-between;
       }
-      .titleHeader {
+      header {
         padding: .75em var(--default-horizontal-margin);
       }
-      .patchRangeHeader {
-        margin: 0 var(--default-horizontal-margin) .75em;
-      }
-      #diff {
-        flex: 1;
-        overflow: auto;
-      }
       .navLink:not([href]) {
         color: #999;
       }
@@ -115,6 +106,9 @@ limitations under the License.
         padding: 0 var(--default-horizontal-margin) 1em;
         color: #666;
       }
+      .subHeader {
+        margin: 0 var(--default-horizontal-margin) .75em;
+      }
       .prefsButton {
         text-align: right;
       }
@@ -141,19 +135,16 @@ limitations under the License.
       }
     </style>
     <header>
-      <div class="titleHeader">
       <h3>
         <a href$="[[_computeChangePath(_changeNum, _patchRange.*, _change.revisions)]]">
           [[_changeNum]]</a><span>:</span>
         <span>[[_change.subject]]</span>
         <span class="dash">—</span>
-          <input
+        <input id="reviewed"
-              id="reviewed"
             class="reviewed"
             type="checkbox"
             on-change="_handleReviewedChange"
-              hidden$="[[!_loggedIn]]"
+            hidden$="[[!_loggedIn]]" hidden>
-              hidden>
         <div class="jumpToFileContainer">
           <gr-button link class="dropdown-trigger" id="trigger" on-tap="_showDropdownTapHandler">
             <span>[[_computeFileDisplayName(_path)]]</span>
@@ -193,9 +184,10 @@ limitations under the License.
         <a class="navLink"
             href$="[[_computeNavLinkURL(_path, _fileList, 1, 1)]]">Next</a>
       </div>
-      </div>
+    </header>
     <div class="loading" hidden$="[[!_loading]]">Loading...</div>
-      <div class="patchRangeHeader" hidden hidden$="[[_loading]]">
+    <div hidden$="[[_loading]]" hidden>
+      <div class="subHeader">
         <gr-patch-range-select
             path="[[_path]]"
             change-num="[[_changeNum]]"
@@ -216,12 +208,12 @@ limitations under the License.
           <span hidden$="[[_computePrefsButtonHidden(_prefs, _loggedIn)]]">
             <span
                 hidden$="[[_computeModeSelectHidden(_isImageDiff)]]">/</span>
-            <gr-button
+            <gr-button link
-                link
                 class="prefsButton"
                 on-tap="_handlePrefsTap">Preferences</gr-button>
           </span>
         </div>
+      </div>
       <gr-overlay id="prefsOverlay" with-backdrop>
         <gr-diff-preferences
             id="diffPreferences"
@@ -230,12 +222,8 @@ limitations under the License.
             on-save="_handlePrefsSave"
             on-cancel="_handlePrefsCancel"></gr-diff-preferences>
       </gr-overlay>
-      </div>
-    </header>
       <gr-diff
           id="diff"
-        hidden
-        hidden$="[[_loading]]"
           project="[[_change.project]]"
           commit="[[_change.current_revision]]"
           is-image-diff="{{_isImageDiff}}"
@@ -248,6 +236,7 @@ limitations under the License.
           view-mode="[[_diffMode]]"
           on-line-selected="_onLineSelected">
       </gr-diff>
+    </div>
     <gr-rest-api-interface id="restAPI"></gr-rest-api-interface>
     <gr-storage id="storage"></gr-storage>
     <gr-diff-cursor id="cursor"></gr-diff-cursor>

polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html

@@ -44,6 +44,7 @@ limitations under the License.
         border-top: 1px solid #eee;
         display: flex;
         font: 12px var(--monospace-font-family);
+        overflow-x: auto;
         will-change: transform;
       }
       table {

polygerrit-ui/app/elements/gr-app.html

@@ -41,8 +41,8 @@ limitations under the License.
     <style>
       :host {
         display: flex;
+        min-height: 100vh;
         flex-direction: column;
-        height: 100vh;
       }
       gr-main-header,
       footer {
@@ -58,7 +58,6 @@ limitations under the License.
       main {
         flex: 1;
         position: relative;
-        overflow: scroll;
       }
       .errorView {
         align-items: center;