opendev/gerrit
Code Issues Proposed changes

NoteDbChangeState: Consistently use ObjectId.zeroId()

Browse Source 
ObjectId.zeroId is imported statically but in most places is called
directly.

Replace the one place it's used statically and remove the static import.

Change-Id: I52ce87ff2c81fbbf7b256ee7bcbf3cbc47bca084
This commit is contained in:
David Pursehouse
2017-01-12 12:10:48 +09:00
parent 3e9fb7fe82
commit cd1cc3823a
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-server/src/main/java/com/google/gerrit/server/notedb/NoteDbChangeState.java
View File

@@ -21,7 +21,6 @@ import static com.google.gerrit.reviewdb.client.RefNames.changeMetaRef;
import static com.google.gerrit.reviewdb.client.RefNames.refsDraftComments;
import static com.google.gerrit.server.notedb.NoteDbChangeState.PrimaryStorage.NOTE_DB;
import static com.google.gerrit.server.notedb.NoteDbChangeState.PrimaryStorage.REVIEW_DB;
import static org.eclipse.jgit.lib.ObjectId.zeroId;
import com.google.auto.value.AutoValue;
import com.google.common.annotations.VisibleForTesting;
@@ -109,7 +108,7 @@ public class NoteDbChangeState {
return new AutoValue_NoteDbChangeState_RefState(
changeMetaId.copy(),
ImmutableMap.copyOf(
Maps.filterValues(draftIds, id -> !zeroId().equals(id))));
Maps.filterValues(draftIds, id -> !ObjectId.zeroId().equals(id))));
}
private static Optional<RefState> parse(Change.Id changeId,