Merge "Fall back to addByEmail for inactive CCs"

2017-04-28 07:19:58 +00:00
parent 005af1ea65 60f3d7742d
commit cd1e144c3d
2 changed files with 30 additions and 0 deletions
--- a/gerrit-server/src/main/java/com/google/gerrit/server/change/PostReviewers.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/PostReviewers.java
@@ -240,6 +240,9 @@ public class PostReviewers implements RestModifyView<ChangeResource, AddReviewer
          reviewer, rsrc, ImmutableSet.of(member.getId()), null, state, notify, accountsToNotify);
    }
    if (!member.isActive()) {
+      if (allowByEmail && state == CC) {
+        return null;
+      }
      return fail(reviewer, MessageFormat.format(ChangeMessages.get().reviewerInactive, reviewer));
    }
    return fail(