opendev/gerrit
Code Issues Proposed changes

Permissions may be lost when matching expanding params

Browse Source 
When we hit the first expanding parameter, no more matching
parameters can be picked up.

This change remove the faulty break.

Change-Id: Ie46652bc4322812a4e1a55cd88e52a0040c6b00b
This commit is contained in:
Gustaf Lundh
2017-04-21 12:38:24 +02:00
parent 831c40cce9
commit cd52ee3497
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-server/src/main/java/com/google/gerrit/server/project/PermissionCollection.java
View File

@@ -98,7 +98,6 @@ public class PermissionCollection {
perUser = true; perUser = true;
if (sm.match(ref, user)) { if (sm.match(ref, user)) {
sectionToProject.put(sm.section, sm.project); sectionToProject.put(sm.section, sm.project);
break;
} }
} else if (sm.match(ref, null)) { } else if (sm.match(ref, null)) {
sectionToProject.put(sm.section, sm.project); sectionToProject.put(sm.section, sm.project);