From cdb631ff28dec4218e8fae01a82fa93a4606d06c Mon Sep 17 00:00:00 2001
From: "Shawn O. Pearce" <sop@google.com>
Date: Sat, 3 Jan 2009 15:00:43 -0800
Subject: [PATCH] Permit all registered users to use the code review -1/+1
 category

This is just reasonable to do, and what Gerrit 1 permits.  Users who
have registered an account may use the -1, 0, +1 values in the CRVW
category (aka "Code Review") to vote on changes, even if they are not
a member of the project.

Signed-off-by: Shawn O. Pearce <sop@google.com>
---
 .../java/com/google/gerrit/server/GerritServer.java    | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/appjar/src/main/java/com/google/gerrit/server/GerritServer.java b/appjar/src/main/java/com/google/gerrit/server/GerritServer.java
index 41d96024eb..32df5ff462 100644
--- a/appjar/src/main/java/com/google/gerrit/server/GerritServer.java
+++ b/appjar/src/main/java/com/google/gerrit/server/GerritServer.java
@@ -20,6 +20,7 @@ import com.google.gerrit.client.data.GitwebLink;
 import com.google.gerrit.client.reviewdb.AccountGroup;
 import com.google.gerrit.client.reviewdb.ApprovalCategory;
 import com.google.gerrit.client.reviewdb.ApprovalCategoryValue;
+import com.google.gerrit.client.reviewdb.ProjectRight;
 import com.google.gerrit.client.reviewdb.ReviewDb;
 import com.google.gerrit.client.reviewdb.SystemConfig;
 import com.google.gerrit.git.RepositoryCache;
@@ -214,6 +215,13 @@ public class GerritServer {
     c.approvalCategories().insert(Collections.singleton(cat), txn);
     c.approvalCategoryValues().insert(vals);
     txn.commit();
+
+    final ProjectRight approve =
+        new ProjectRight(new ProjectRight.Key(ProjectRight.WILD_PROJECT, cat
+            .getId(), sConfig.registeredGroupId));
+    approve.setMaxValue((short) 1);
+    approve.setMinValue((short) -1);
+    c.projectRights().insert(Collections.singleton(approve));
   }
 
   private void initSubmitCategory(final ReviewDb c) throws OrmException {
@@ -253,10 +261,10 @@ public class GerritServer {
         // Assume the schema is empty and populate it.
         //
         initSystemConfig(c);
+        sConfig = c.systemConfig().get(new SystemConfig.Key());
         initVerifiedCategory(c);
         initCodeReviewCategory(c);
         initSubmitCategory(c);
-        sConfig = c.systemConfig().get(new SystemConfig.Key());
       }
 
       loadGerritConfig(c);