opendev/gerrit
Code Issues Proposed changes

Merge branch 'stable-2.16' into stable-3.0

Browse Source 
* stable-2.16:
  Correctly setting the value of manual_review
  Revert "Update polymer-resin to 2.0.0"
  Update polymer-resin to 2.0.0
  Update polymer-resin to 1.2.8

Change-Id: I2cbb873fb66e2efbffaf422bbd2e7f082ad840af
This commit is contained in:
David Pursehouse
2019-05-11 06:33:16 +09:00
parent 62c8b72009 ef6ebcdd2f
commit ce6588df21
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
polygerrit-ui/app/elements/shared/gr-diff-preferences/gr-diff-preferences.html
View File

@@ -135,7 +135,7 @@ limitations under the License.
<input <input
id="automaticReviewInput" id="automaticReviewInput"
type="checkbox" type="checkbox"
checked$="[[diffPrefs.manual_review]]" checked$="[[!diffPrefs.manual_review]]"
on-change="_handleAutomaticReviewTap"> on-change="_handleAutomaticReviewTap">
</span> </span>
</section> </section>

2
polygerrit-ui/app/elements/shared/gr-diff-preferences/gr-diff-preferences.js
View File

@@ -66,7 +66,7 @@
_handleAutomaticReviewTap() { _handleAutomaticReviewTap() {
this.set('diffPrefs.manual_review', this.set('diffPrefs.manual_review',
this.$.automaticReviewInput.checked); !this.$.automaticReviewInput.checked);
this._handleDiffPrefsChanged(); this._handleDiffPrefsChanged();
}, },

2
polygerrit-ui/app/elements/shared/gr-diff-preferences/gr-diff-preferences_test.html
View File

@@ -96,7 +96,7 @@ limitations under the License.
.firstElementChild.checked, diffPreferences.syntax_highlighting); .firstElementChild.checked, diffPreferences.syntax_highlighting);
assert.equal( assert.equal(
valueOf('Automatically mark viewed files reviewed', 'diffPreferences') valueOf('Automatically mark viewed files reviewed', 'diffPreferences')
.firstElementChild.checked, diffPreferences.manual_review); .firstElementChild.checked, !diffPreferences.manual_review);
assert.equal(valueOf('Ignore Whitespace', 'diffPreferences') assert.equal(valueOf('Ignore Whitespace', 'diffPreferences')
.firstElementChild.bindValue, diffPreferences.ignore_whitespace); .firstElementChild.bindValue, diffPreferences.ignore_whitespace);