From ce76802d5cb79933446045fb25faa26e39fa6e0c Mon Sep 17 00:00:00 2001 From: David Ostrovsky Date: Wed, 17 Jun 2015 21:40:08 +0200 Subject: [PATCH] Buck: Simplify build rules Since [1] dependencies to targets used in $(location //path/to:target) macro are added implicitly. This can be verified by using Bucks audit and targets commands: $ buck targets --json api [...] "buck.type" : "genrule", "name" : "api", "deps" : [ ], [...] So explicit dependencies are empty, but implicit dependencies are still present: $ buck audit dependencies api //gerrit-extension-api:extension-api //gerrit-extension-api:extension-api-javadoc //gerrit-extension-api:extension-api-src //gerrit-plugin-api:plugin-api //gerrit-plugin-api:plugin-api-javadoc //gerrit-plugin-api:plugin-api-src //gerrit-plugin-gwtui:gwtui-api //gerrit-plugin-gwtui:gwtui-api-javadoc //gerrit-plugin-gwtui:gwtui-api-src [1] https://github.com/facebook/buck/issues/128 Change-Id: I6c8ddb40ef95ee45f6b6605e74381d55524229af --- BUCK | 1 - 1 file changed, 1 deletion(-) diff --git a/BUCK b/BUCK index f6dab1b393..4dd69c3dab 100644 --- a/BUCK +++ b/BUCK @@ -26,7 +26,6 @@ genrule( ['cd $TMP'] + ['ln -s $(location %s) .' % n for n in API_DEPS] + ['zip -q0 $OUT *']), - deps = API_DEPS, out = 'api.zip', )