opendev/gerrit
Code Issues Proposed changes

Allow to specify multiple 'footer' tags per trackingid entry

Browse Source 
The documentation says:

  "A single trackingid entry can have multiple footer tags"

However the implementation was only considering the first one
that was listed. So for a configuration like:

    [trackingid "jira-bug"]
      footer = Bugfix:
      footer = Bug:
      match = JRA\\d{2,8}
      system = JIRA

only "Bugfix:" would be considered, and "Bug:" would be ignored.

Fix it so that all footer tags are recognized.

Change-Id: Ib6706d0743bb9a2fd116cb260c8e4270e765c91a
This commit is contained in:
David Pursehouse
2015-02-19 14:52:45 +09:00
parent 2b3a38fe2a
commit ce7f68675b
2 changed files with 22 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
Documentation/config-gerrit.txt
View File

@@ -3363,6 +3363,7 @@ bug:<tracking id>.
----
[trackingid "jira-bug"]
footer = Bugfix:
footer = Bug:
match = JRA\\d{2,8}
system = JIRA
@@ -3374,11 +3375,15 @@ bug:<tracking id>.
[[trackingid.name.footer]]trackingid.<name>.footer::
+
A prefix tag that identify the footer line to parse for tracking ids.
Several trackingid entries can have the same footer tag. A single
trackingid entry can have multiple footer tags. If multiple footer
tags are specified, each tag will be parsed separately.
(the trailing ":" is optional)
A prefix tag that identifies the footer line to parse for tracking ids.
+
Several trackingid entries can have the same footer tag, and a single trackingid
entry can have multiple footer tags.
+
If multiple footer tags are specified, each tag will be parsed separately and
duplicates will be ignored.
+
The trailing ":" is optional.
[[trackingid.name.match]]trackingid.<name>.match::
+