opendev/gerrit
Code Issues Proposed changes

Fix Eclipse project generation when plugins without tags are present

Browse Source 
If a plugin is symlinked in the plugins folder, and that plugin does
not have any tags, the `git describe` command fails with:

  fatal: No names found, cannot describe anything

which causes the build to fail. This was broken by change If5e7be8d.

Add the `--always` option on `git describe` so that it will return a
value even when there are no tags.

Change-Id: I3d0c472c9ac469d079626a9df17149422dc5e4e6
This commit is contained in:
David Pursehouse 2015-04-14 17:49:21 +09:00
parent 3bff7aa620
commit ce96b3ff85
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/git.defs
View File

@ -14,7 +14,7 @@
def git_describe(plugin = None): def git_describe(plugin = None):
import subprocess import subprocess
cmd = ['git', 'describe', '--match', 'v[0-9].*', '--dirty'] cmd = ['git', 'describe', '--always', '--match', 'v[0-9].*', '--dirty']
if not plugin or plugin == '${pluginName}': if not plugin or plugin == '${pluginName}':
p = subprocess.Popen(cmd, stdout = subprocess.PIPE) p = subprocess.Popen(cmd, stdout = subprocess.PIPE)
else: else: