opendev/gerrit
Code Issues Proposed changes

Update git submodules

Browse Source 
* Update plugins/commit-message-length-validator from branch 'master'
  to 315a11558913fa8f9c6d3b1723e45583b25afa1c
  - Prefer using Splitter to String.split
    
    String.split(String) has surprising behaviour [1]:
    
    String[] nothing = "".split(":"); // results in [""]
    String[] bunchOfNothing = ":".split(":"); // results in []
    
    More examples:
    
    input  | input.split(":")  | Splitter.on(':').split(input)
    =======|===================|==============================
    ""     | [""]              | [""]
    ":"    | []                | ["", ""]
    ":::"  | []                | ["", "", "", ""]
    "a:::" | ["a"]             | ["a", "", "", ""]
    ":::b" | ["", "", "", "b"] | ["", "", "", "b"]
    
    Tests and classes that are used by the GWT UI are not adapted.
    
    [1] http://konigsberg.blogspot.com/2009/11/final-thoughts-java-puzzler-splitting.html
    
    Change-Id: Ib9534727a9fe1840eecb86e4141ca3fe9d997936
    Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin 2018-02-09 16:50:20 +01:00 committed by Gerrit Code Review
parent a4c07f4efa
commit cf18afe357
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/commit-message-length-validator

@ -1 +1 @@
Subproject commit 3f96a82f15d9d592a86a989874b160567cd66f53
Subproject commit 315a11558913fa8f9c6d3b1723e45583b25afa1c