Use #/settings in user popdown panel

Instead of linking to /settings which causes a GWT UI reload,
use #/settings allowing the UI to be replaced. This fixes a
visible glitch when clicking Settings in debug mode and Buck
is kicked off to update the JS code, and even in production
installations when the server is far away from the user.

Change-Id: I0c57d6d93eaf9f102ad78e362cbbada1785853e4
This commit is contained in:
Shawn Pearce
2013-08-27 17:20:44 -07:00
parent f57c0e7459
commit cf61ee1f66
2 changed files with 8 additions and 6 deletions

View File

@@ -17,7 +17,8 @@ limitations under the License.
<!DOCTYPE ui:UiBinder SYSTEM "http://dl.google.com/gwt/DTD/xhtml.ent">
<ui:UiBinder xmlns:ui='urn:ui:com.google.gwt.uibinder'
xmlns:g='urn:import:com.google.gwt.user.client.ui'
xmlns:gerrit='urn:import:com.google.gerrit.client'>
xmlns:gerrit='urn:import:com.google.gerrit.client'
xmlns:u='urn:import:com.google.gerrit.client.ui'>
<ui:with field='constants' type='com.google.gerrit.client.GerritConstants'/>
<ui:style>
@@ -51,9 +52,9 @@ limitations under the License.
<g:Label ui:field='userName' styleName="{style.userName}" />
<g:Label ui:field='userEmail' styleName="{style.email}" />
</td></tr></table>
<g:Anchor ui:field='settings'>
<ui:text from='{constants.menuSettings}' />
</g:Anchor>
<u:InlineHyperlink ui:field='settings'>
<ui:msg>Settings</ui:msg>
</u:InlineHyperlink>
<g:Anchor ui:field='logout' styleName="{style.logout}">
<ui:text from='{constants.menuSignOut}' />
</g:Anchor>