opendev/gerrit
Code Issues Proposed changes

Merge "Cache RefControl.isVisible()"

Browse Source
This commit is contained in:
Shawn Pearce
2012-12-19 21:28:12 -08:00
committed by Gerrit Code Review
parent d1e0d890a6 ea54833711
commit cf81aa4915
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java
View File

@@ -58,6 +58,7 @@ public class RefControl {
private Boolean owner; private Boolean owner;
private Boolean canForgeAuthor; private Boolean canForgeAuthor;
private Boolean canForgeCommitter; private Boolean canForgeCommitter;
private Boolean isVisible;
RefControl(ProjectControl projectControl, String ref, RefControl(ProjectControl projectControl, String ref,
PermissionCollection relevant) { PermissionCollection relevant) {
@@ -103,8 +104,12 @@ public class RefControl {
/** Can this user see this reference exists? */ /** Can this user see this reference exists? */
public boolean isVisible() { public boolean isVisible() {
return (getCurrentUser() instanceof InternalUser || canPerform(Permission.READ)) if (isVisible == null) {
&& canRead(); isVisible =
(getCurrentUser() instanceof InternalUser || canPerform(Permission.READ))
&& canRead();
}
return isVisible;
} }
/** /**