opendev/gerrit
Code Issues Proposed changes

Address post-submit review of CheckAccess

Browse Source 
Change-Id: I1b361d081b5fe79266c0f67e9ae17f1e1064ebbf
This commit is contained in:
Han-Wen Nienhuys
2017-04-28 11:57:41 +02:00
parent 9288100fe3
commit d0128b0822
5 changed files with 14 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-server/src/main/java/com/google/gerrit/server/api/config/ServerImpl.java
View File

@@ -33,6 +33,7 @@ import com.google.gerrit.server.config.GetServerInfo;
import com.google.gerrit.server.config.SetDiffPreferences;
import com.google.gerrit.server.config.SetPreferences;
import com.google.gerrit.server.permissions.PermissionBackendException;
import com.google.gwtorm.server.OrmException;
import com.google.inject.Inject;
import com.google.inject.Provider;
import com.google.inject.Singleton;
@@ -132,7 +133,7 @@ public class ServerImpl implements Server {
public AccessCheckInfo checkAccess(AccessCheckInput in) throws RestApiException {
try {
return checkAccess.get().apply(new ConfigResource(), in);
} catch (IOException | PermissionBackendException e) {
} catch (OrmException | IOException | PermissionBackendException e) {
throw new RestApiException("Cannot check access", e);
}
}