opendev/gerrit
Code Issues Proposed changes

Fix missing return after %submit is rejected

Browse Source 
Using %submit is currently only allowed if the caller has
Submit granted on refs/for/$branch. Early return once it
is known submit permission is missing.

Change-Id: I8da76454bf1efdf9fbc9ec662e1711489dbce009
This commit is contained in:
Shawn Pearce
2014-12-10 16:40:04 -08:00
parent b364901445
commit d07a5ab586
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
View File

@@ -1315,6 +1315,7 @@ public class ReceiveCommits {
if (magicBranch.isSubmit() && !projectControl.controlForRef( if (magicBranch.isSubmit() && !projectControl.controlForRef(
MagicBranch.NEW_CHANGE + ref).canSubmit()) { MagicBranch.NEW_CHANGE + ref).canSubmit()) {
reject(cmd, "submit not allowed"); reject(cmd, "submit not allowed");
return;
} }
RevWalk walk = rp.getRevWalk(); RevWalk walk = rp.getRevWalk();