opendev/gerrit
Code Issues Proposed changes

Revert "Remove highlight.js js_component"

Browse Source 
This reverts commit a7f0e62938.

The //lib/js:highlightjs in
//polygerrit-ui:polygerrit_components.bower_components appeared to be
unused because the library is specially inserted into the PG app bundle
in polygerrit-ui/app/rules.bzl. However, it was used by development
servers such as the WAR using --polygerrit-dev or by the run-server.sh
proxy.

Bug: Issue 8777
Change-Id: Ie1467ed9bc9f7e011c870629ba1c9390fa0c9559
This commit is contained in:
Wyatt Allen 2018-04-17 16:14:37 +02:00
parent ee33087e12
commit d09f1c6d59
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/js/BUILD
View File

@ -24,6 +24,12 @@ load("//lib/js:bower_components.bzl", "define_bower_components")
define_bower_components()
js_component(
name = "highlightjs",
srcs = ["//lib/highlightjs:highlight.min.js"],
license = "//lib:LICENSE-highlightjs",
)
filegroup(
name = "highlightjs_files",
srcs = ["//lib/highlightjs:highlight.min.js"],

3
polygerrit-ui/BUILD
View File

@ -11,6 +11,9 @@ bower_component_bundle(
"//lib/js:ba-linkify",
"//lib/js:es6-promise",
"//lib/js:fetch",
# Although highlightjs is inserted separately in the UI zip, it's used
# by local development servers (e.g. --polygerrit-dev or run-server.sh).
"//lib/js:highlightjs",
"//lib/js:iron-a11y-keys-behavior",
"//lib/js:iron-autogrow-textarea",
"//lib/js:iron-dropdown",