From d0bdeca6982f60a3fd92780a0e630892bc76cf2f Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Tue, 28 Aug 2018 16:42:08 +0900 Subject: [PATCH] SshCommandsIT: Use immutable type for constant field declarations ErrorProne warns [1] that constant field declarations should use the immutable type (such as ImmutableList) instead of the general collection interface type (such as List). [1] http://errorprone.info/bugpattern/MutableConstantField Change-Id: If42c500891ea0eb90e753620b6c1e251336217e1 --- .../java/com/google/gerrit/acceptance/ssh/SshCommandsIT.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/ssh/SshCommandsIT.java b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/ssh/SshCommandsIT.java index 1e2971c80f..8a55aea8d7 100644 --- a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/ssh/SshCommandsIT.java +++ b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/ssh/SshCommandsIT.java @@ -26,7 +26,6 @@ import com.google.gerrit.acceptance.UseSsh; import com.google.gerrit.common.data.GlobalCapability; import com.google.gerrit.sshd.Commands; import java.util.List; -import java.util.Map; import org.junit.Test; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -37,7 +36,7 @@ public class SshCommandsIT extends AbstractDaemonTest { private static final Logger log = LoggerFactory.getLogger(SshCommandsIT.class); // TODO: It would be better to dynamically generate this list - private static final Map> COMMANDS = + private static final ImmutableMap> COMMANDS = ImmutableMap.of( Commands.ROOT, ImmutableList.of(