opendev/gerrit
Code Issues Proposed changes

Assume labels are correct in ListChanges

Browse Source 
To reduce end-user latency when displaying changes in a search result
or user dashboard, assume the labels are accurate in the database at
display time and don't recompute the access privileges of a reviewer.

Change-Id: I1316adf627e88fdcde1cd845444d56da9abaeb57
This commit is contained in:
Shawn O. Pearce
2012-05-02 15:20:07 -07:00
parent 4502dfbde0
commit d0df169822
3 changed files with 24 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
gerrit-server/src/main/prolog/gerrit_common.pl
View File

@@ -25,8 +25,7 @@
%% predicate that needs to obtain it.
%%
init :-
define_hash(commit_labels),
define_hash(current_user).
define_hash(commit_labels).
define_hash(A) :- hash_exists(A), !, hash_clear(A).
define_hash(A) :- atom(A), !, new_hash(_, [alias(A)]).
@@ -97,6 +96,10 @@ index_commit_labels([_ | Rs]) :-
%%
%% Lookup the range allowed to be used.
%%
user_label_range(Label, Who, Min, Max) :-
hash_get(commit_labels, '$fast_range', true), !,
atom(Label),
assume_range_from_label(Label, Who, Min, Max).
user_label_range(Label, Who, Min, Max) :-
Who = user(_), !,
atom(Label),
@@ -106,6 +109,14 @@ user_label_range(Label, test_user(Name), Min, Max) :-
clause(user:test_grant(Label, test_user(Name), range(Min, Max)), _)
.
assume_range_from_label :-
hash_put(commit_labels, '$fast_range', true).
assume_range_from_label(Label, Who, Min, Max) :-
commit_label(label(Label, Value), Who), !,
Min = Value, Max = Value.
assume_range_from_label(_, _, 0, 0).
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%