gr-create-change-dialog: Pass private-by-defaut value

Allow to propagate private-by-defaut configuration value. It also avoids
unnecessary requests, when invoked from the change view, because the
project configuration was already retrieved and can be just re-used.

Bug: Issue 8601
Change-Id: I5cdb3f0e12c53bf656653b0821c94317ba7fbb2d

polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.html

@@ -104,7 +104,7 @@ limitations under the License.
             <input
                 type="checkbox"
                 id="privateChangeCheckBox"
-                checked$="[[_formatBooleanString(_repoConfig.private_by_default)]]">
+                checked$="[[_formatBooleanString(privateByDefault)]]">
           </span>
         </section>
       </div>

polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.js

@@ -34,6 +34,7 @@
         },
       },
       baseChange: String,
+      privateByDefault: String,
       canCreate: {
         type: Boolean,
         notify: true,
@@ -47,8 +48,9 @@
     ],
 
     attached() {
+      if (!this.repoName) { return; }
       this.$.restAPI.getProjectConfig(this.repoName).then(config => {
-        this._repoConfig = config;
+        this.privateByDefault = config.private_by_default;
       });
     },
 

polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog_test.html

@@ -102,11 +102,9 @@ limitations under the License.
     });
 
     test('new change created with private', done => {
-      element._repoConfig = {
-        private_by_default: {
-          configured_value: 'TRUE',
-          inherited_value: false,
-        },
+      element.privateByDefault = {
+        configured_value: 'TRUE',
+        inherited_value: false,
       };
       sandbox.stub(element, '_formatBooleanString', () => {
         return Promise.resolve(true);

polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.html

@@ -174,7 +174,8 @@ limitations under the License.
               id="createFollowUpChange"
               branch="[[change.branch]]"
               base-change="[[change.id]]"
-              repo-name="[[change.project]]"></gr-create-change-dialog>
+              repo-name="[[change.project]]"
+              private-by-default="[[privateByDefault]]"></gr-create-change-dialog>
         </div>
       </gr-confirm-dialog>
       <gr-confirm-dialog

polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js

@@ -233,6 +233,7 @@
         type: Object,
         value() { return {}; },
       },
+      privateByDefault: String,
 
       _loading: {
         type: Boolean,

polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html

@@ -394,6 +394,7 @@ limitations under the License.
               edit-patchset-loaded="[[hasEditPatchsetLoaded(_patchRange.*)]]"
               edit-mode="[[_editMode]]"
               edit-based-on-current-patch-set="[[hasEditBasedOnCurrentPatchSet(_allPatchSets)]]"
+              private-by-default="[[_projectConfig.private_by_default]]"
               on-reload-change="_handleReloadChange"
               on-edit-tap="_handleEditTap"
               on-stop-edit-tap="_handleStopEditTap"