opendev/gerrit
Code Issues Proposed changes

Return concrete type from SetDiffPreferences#apply method, not Object

Browse Source 
Change-Id: I6d28912918b7dc5fe2d491732fdb200e0a326d4e
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2016-06-03 13:45:54 +02:00
parent d565142e2d
commit d1106b2c0d
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-server/src/main/java/com/google/gerrit/server/config/SetDiffPreferences.java
View File

@@ -60,7 +60,8 @@ public class SetDiffPreferences implements
} }
@Override @Override
public Object apply(ConfigResource configResource, DiffPreferencesInfo in) public DiffPreferencesInfo apply(ConfigResource configResource,
DiffPreferencesInfo in)
throws BadRequestException, IOException, ConfigInvalidException { throws BadRequestException, IOException, ConfigInvalidException {
if (in == null) { if (in == null) {
throw new BadRequestException("input must be provided"); throw new BadRequestException("input must be provided");