diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/change/CommentsTest.java b/gerrit-server/src/test/java/com/google/gerrit/server/change/CommentsTest.java index 0f0cc971a4..4f64a67db1 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/server/change/CommentsTest.java +++ b/gerrit-server/src/test/java/com/google/gerrit/server/change/CommentsTest.java @@ -303,7 +303,7 @@ public class CommentsTest { } private Change newChange() { - return TestChanges.newChange(project, changeOwner); + return TestChanges.newChange(project, changeOwner.getAccountId()); } private ChangeUpdate newUpdate(Change c, final IdentifiedUser user) throws Exception { diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/notedb/AbstractChangeNotesTest.java b/gerrit-server/src/test/java/com/google/gerrit/server/notedb/AbstractChangeNotesTest.java index f73c1c2df8..c7a76d37b2 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/server/notedb/AbstractChangeNotesTest.java +++ b/gerrit-server/src/test/java/com/google/gerrit/server/notedb/AbstractChangeNotesTest.java @@ -170,7 +170,7 @@ public class AbstractChangeNotesTest { } protected Change newChange() { - return TestChanges.newChange(project, changeOwner); + return TestChanges.newChange(project, changeOwner.getAccountId()); } protected ChangeUpdate newUpdate(Change c, IdentifiedUser user) diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/notedb/CommitMessageOutputTest.java b/gerrit-server/src/test/java/com/google/gerrit/server/notedb/CommitMessageOutputTest.java index eef6456775..86f9702f83 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/server/notedb/CommitMessageOutputTest.java +++ b/gerrit-server/src/test/java/com/google/gerrit/server/notedb/CommitMessageOutputTest.java @@ -36,7 +36,7 @@ import java.util.TimeZone; public class CommitMessageOutputTest extends AbstractChangeNotesTest { @Test public void approvalsCommitFormatSimple() throws Exception { - Change c = TestChanges.newChange(project, changeOwner, 1); + Change c = TestChanges.newChange(project, changeOwner.getAccountId(), 1); ChangeUpdate update = newUpdate(c, changeOwner); update.putApproval("Verified", (short) 1); update.putApproval("Code-Review", (short) -1); @@ -71,7 +71,7 @@ public class CommitMessageOutputTest extends AbstractChangeNotesTest { @Test public void changeMessageCommitFormatSimple() throws Exception { - Change c = TestChanges.newChange(project, changeOwner, 1); + Change c = TestChanges.newChange(project, changeOwner.getAccountId(), 1); ChangeUpdate update = newUpdate(c, changeOwner); update.setChangeMessage("Just a little code change.\n" + "How about a new line"); diff --git a/gerrit-server/src/test/java/com/google/gerrit/testutil/TestChanges.java b/gerrit-server/src/test/java/com/google/gerrit/testutil/TestChanges.java index 0e9a681273..fc5718d4ce 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/testutil/TestChanges.java +++ b/gerrit-server/src/test/java/com/google/gerrit/testutil/TestChanges.java @@ -18,6 +18,7 @@ import static org.easymock.EasyMock.expect; import com.google.common.collect.Ordering; import com.google.gerrit.common.TimeUtil; +import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.Branch; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.PatchSet; @@ -47,17 +48,17 @@ import java.util.concurrent.atomic.AtomicInteger; public class TestChanges { private static final AtomicInteger nextChangeId = new AtomicInteger(1); - public static Change newChange(Project.NameKey project, IdentifiedUser user) { - return newChange(project, user, nextChangeId.getAndIncrement()); + public static Change newChange(Project.NameKey project, Account.Id userId) { + return newChange(project, userId, nextChangeId.getAndIncrement()); } - public static Change newChange(Project.NameKey project, IdentifiedUser user, + public static Change newChange(Project.NameKey project, Account.Id userId, int id) { Change.Id changeId = new Change.Id(id); Change c = new Change( new Change.Key("Iabcd1234abcd1234abcd1234abcd1234abcd1234"), changeId, - user.getAccount().getId(), + userId, new Branch.NameKey(project, "master"), TimeUtil.nowTs()); incrementPatchSet(c);