opendev/gerrit
Code Issues Proposed changes

Show "create change" button even when no actions returned

Browse Source 
Change-Id: I68b85fbca9f9aa2baab99e5bb7f8a573eeac20da
This commit is contained in:
Dave Borowitz
2014-09-17 13:30:13 -07:00
parent 93ca7e03b9
commit d2468d3336
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectInfoScreen.java
View File

@@ -554,9 +554,13 @@ public class ProjectInfoScreen extends ProjectScreen {
private void initProjectActions(ConfigInfo info) { private void initProjectActions(ConfigInfo info) {
actionsGrid.clear(true); actionsGrid.clear(true);
actionsGrid.removeAllRows(); actionsGrid.removeAllRows();
boolean showCreateChange = Gerrit.isSignedIn();
NativeMap<ActionInfo> actions = info.actions(); NativeMap<ActionInfo> actions = info.actions();
if (actions == null || actions.isEmpty()) { if (actions == null) {
actions = NativeMap.create().cast();
}
if (actions.isEmpty() && !showCreateChange) {
return; return;
} }
actions.copyKeysIntoChildren("id"); actions.copyKeysIntoChildren("id");
@@ -571,7 +575,9 @@ public class ProjectInfoScreen extends ProjectScreen {
actions.get(id))); actions.get(id)));
} }
if (Gerrit.isSignedIn()) { // TODO: The user should have create permission on the branch referred to by
// HEAD. This would have to happen on the server side.
if (showCreateChange) {
actionsPanel.add(createChangeAction()); actionsPanel.add(createChangeAction());
} }
} }