opendev/gerrit
Code Issues Proposed changes

Update git submodules

Browse Source 
* Update plugins/replication from branch 'stable-2.16'
  to 04bd5274b5b9d852989f92ad42a3ceea3f917238
  - PushOneTest: Remove unused mock ReplicationQueue
    
    Change-Id: I162fb33059ef954b437d230cef05f732752dc137
    
  - ReplicationStateTest: Remove unused mock ReplicationTasksStorage
    
    Change-Id: I285805381512d76437ad740764697784b8f39c9e
    
  - Wrap calls to createProject in a utility method
    
    The createProject method is removed in stable-3.0, and creating a test
    project must be done with the ProjectOperations class. This means that
    when a new test is added in stable-2.16 and uses createProject, there
    is a conflict when merging it up to stable-3.0.
    
    Wrap all the calls to createProject in a new utility method and call
    that instead in the tests. This commit will conflict on the next merge
    up to stable-3.0, but then there will be no more conflicts in future.
    
    Change-Id: I271d0d55cd07c25eb4c6f8acc47d144b47600356
    
  - ReplicationIT: stop using EasyMock
    
    Integration tests should never use mocks as they are always
    supposed to use the real implementation and the integration
    between components.
    
    Remove the use of EasyMock as it has a very limited
    contribution and impact on ReplicationIT.
    
    Change-Id: I61d42c69164484486187f123a2fa26f8810c1924
This commit is contained in:
David Pursehouse
2019-09-19 15:49:29 +09:00
committed by Gerrit Code Review
parent 91d2e2f370
commit d24f5b9d68
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files