opendev/gerrit
Code Issues Proposed changes

Rename AddToAttentionSetInput to AttentionSetInput

Browse Source 
This is because in the follow-up change, we will use AttentionSetInput
for both adding and removing users from the attention set. However,
RemoveFromAttentionSet doesn't work for this case since we need
the user to be a part of the input.

Also, in a follow-up change, we can consider removing
RemoveFromAttentionSetInput and only use AttentionSetInput.

Change-Id: I28ba68a24242010f980f8ac833898f433af810e6
This commit is contained in:
Gal Paikin
2020-06-14 13:16:10 +03:00
parent 8bf2a18575
commit d274f391ce
8 changed files with 28 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/com/google/gerrit/server/api/changes/ChangeApiImpl.java
View File

@@ -23,9 +23,9 @@ import com.google.gerrit.exceptions.StorageException;
import com.google.gerrit.extensions.api.changes.AbandonInput;
import com.google.gerrit.extensions.api.changes.AddReviewerInput;
import com.google.gerrit.extensions.api.changes.AddReviewerResult;
import com.google.gerrit.extensions.api.changes.AddToAttentionSetInput;
import com.google.gerrit.extensions.api.changes.AssigneeInput;
import com.google.gerrit.extensions.api.changes.AttentionSetApi;
import com.google.gerrit.extensions.api.changes.AttentionSetInput;
import com.google.gerrit.extensions.api.changes.ChangeApi;
import com.google.gerrit.extensions.api.changes.ChangeEditApi;
import com.google.gerrit.extensions.api.changes.ChangeMessageApi;
@@ -543,7 +543,7 @@ class ChangeApiImpl implements ChangeApi {
}
@Override
public AccountInfo addToAttentionSet(AddToAttentionSetInput input) throws RestApiException {
public AccountInfo addToAttentionSet(AttentionSetInput input) throws RestApiException {
try {
return addToAttentionSet.apply(change, input).value();
} catch (Exception e) {