opendev/gerrit
Code Issues Proposed changes

Revert "Scroll from the window when rendering entire file"

Browse Source 
This reverts commit b07a26f2eb.
Codemirror expects to be able to scroll Codemirror instance in
order to execute any line navigation. Furthermore, horizontal
scrollbars are rendered in the Codemirror at the bottom of the
document (not window). In order to have a "window" scroll bar,
we would likely have to steal the scroll bars inside Codemirror
and make it look like the window scroll bar.

Change-Id: I3199edc039ba716723eaf8032eaa5355c2100666
This commit is contained in:
Colby Ranger
2014-01-13 08:28:54 -08:00
parent c73bcab298
commit d29c67d4a2
4 changed files with 13 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/PreferencesBox.ui.xml
View File

@@ -33,7 +33,6 @@ limitations under the License.
font-family: arial,sans-serif;
font-weight: bold;
overflow: hidden;
position: fixed !important;
text-align: left;
text-shadow: 1px 1px 7px #000000;
min-width: 300px;