opendev/gerrit
Code Issues Proposed changes

Change Size column to show +X, -Y instead of a bar

Browse Source 
Users hate the colored bar. It is inappropiate for a tool to be
deciding some changes get green bars and others get red bars.

The decision for the bar to be full width at some line count is
arbitrary and does not reflect what individual users think to be
a reasonable size change. Reasonable sizes can even vary between
projects on the same server.

Get rid of the bar and simply display "+X, -Y".

Change-Id: I3e3ff82dcb734f52b92cb1720b3f3f51ac119991
This commit is contained in:
Shawn Pearce
2013-12-05 17:24:56 -08:00
parent c53b447e16
commit d2fc715327
1 changed files with 1 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeTable2.java
View File

@@ -38,7 +38,6 @@ import com.google.gwt.user.client.ui.HTMLTable.Cell;
import com.google.gwt.user.client.ui.HTMLTable.CellFormatter; import com.google.gwt.user.client.ui.HTMLTable.CellFormatter;
import com.google.gwt.user.client.ui.Image; import com.google.gwt.user.client.ui.Image;
import com.google.gwt.user.client.ui.InlineLabel; import com.google.gwt.user.client.ui.InlineLabel;
import com.google.gwt.user.client.ui.SimplePanel;
import com.google.gwt.user.client.ui.UIObject; import com.google.gwt.user.client.ui.UIObject;
import com.google.gwt.user.client.ui.Widget; import com.google.gwt.user.client.ui.Widget;
@@ -227,8 +226,7 @@ public class ChangeTable2 extends NavigationTable<ChangeInfo> {
} else { } else {
table.setText(row, C_LAST_UPDATE, shortFormat(c.updated())); table.setText(row, C_LAST_UPDATE, shortFormat(c.updated()));
} }
table.setWidget(row, C_SIZE, getSizeWidget(c)); table.setText(row, C_SIZE,
fmt.getElement(row, C_SIZE).setTitle(
Util.M.insertionsAndDeletions(c.insertions(), c.deletions())); Util.M.insertionsAndDeletions(c.insertions(), c.deletions()));
boolean displayName = Gerrit.isSignedIn() && Gerrit.getUserAccount() boolean displayName = Gerrit.isSignedIn() && Gerrit.getUserAccount()
@@ -306,31 +304,6 @@ public class ChangeTable2 extends NavigationTable<ChangeInfo> {
setRowItem(row, c); setRowItem(row, c);
} }
private static Widget getSizeWidget(ChangeInfo c) {
int largeChangeSize = Gerrit.getConfig().getLargeChangeSize();
int changedLines = c.insertions() + c.deletions();
int p = 100;
if (changedLines < largeChangeSize) {
p = Math.round(changedLines * 100 / largeChangeSize);
}
int width = Math.max(2, 70 * p / 100);
int red = p > 50 ? 255 : (int) Math.round((p) * 5.12);
int green = p < 50 ? 255 : (int) Math.round(256 - (p - 50) * 5.12);
String bg = "#" + toHex(red) + toHex(green) + "00";
SimplePanel panel = new SimplePanel();
panel.setStyleName(Gerrit.RESOURCES.css().changeSize());
panel.setWidth(width + "px");
panel.getElement().getStyle().setBackgroundColor(bg);
return panel;
}
private static String toHex(int i) {
String hex = Integer.toHexString(i);
return hex.length() == 1 ? "0" + hex : hex;
}
public void addSection(final Section s) { public void addSection(final Section s) {
assert s.parent == null; assert s.parent == null;