opendev/gerrit
Code Issues Proposed changes

Test that account is removed from cache/index on deletion of user branch

Browse Source 
Change-Id: I28aec0d314c6a2b188e9c1b837197d6ae50bb58e
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2017-08-03 11:40:09 +02:00
committed by David Pursehouse
parent cc8de7756b
commit d308196cd5
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/accounts/AccountIT.java
View File

@@ -44,6 +44,7 @@ import com.google.common.io.BaseEncoding;
import com.google.common.util.concurrent.AtomicLongMap; import com.google.common.util.concurrent.AtomicLongMap;
import com.google.gerrit.acceptance.AbstractDaemonTest; import com.google.gerrit.acceptance.AbstractDaemonTest;
import com.google.gerrit.acceptance.AccountCreator; import com.google.gerrit.acceptance.AccountCreator;
import com.google.gerrit.acceptance.GerritConfig;
import com.google.gerrit.acceptance.PushOneCommit; import com.google.gerrit.acceptance.PushOneCommit;
import com.google.gerrit.acceptance.Sandboxed; import com.google.gerrit.acceptance.Sandboxed;
import com.google.gerrit.acceptance.TestAccount; import com.google.gerrit.acceptance.TestAccount;
@@ -1019,6 +1020,7 @@ public class AccountIT extends AbstractDaemonTest {
@Test @Test
@Sandboxed @Sandboxed
@GerritConfig(name = "user.readAccountsFromGit", value = "true")
public void deleteUserBranchWithAccessDatabaseCapability() throws Exception { public void deleteUserBranchWithAccessDatabaseCapability() throws Exception {
allowGlobalCapabilities(REGISTERED_USERS, GlobalCapability.ACCESS_DATABASE); allowGlobalCapabilities(REGISTERED_USERS, GlobalCapability.ACCESS_DATABASE);
grant( grant(
@@ -1038,7 +1040,8 @@ public class AccountIT extends AbstractDaemonTest {
assertThat(repo.exactRef(userRef)).isNull(); assertThat(repo.exactRef(userRef)).isNull();
} }
// TODO(ekempin): assert that account was deleted from cache and index assertThat(accountCache.getOrNull(admin.id)).isNull();
assertThat(accountQuery.byDefault(admin.id.toString())).isEmpty();
} }
@Test @Test