opendev/gerrit
Code Issues Proposed changes

Fix: 'Illegal label name'

Browse Source 
review command like

 'ssh -p 29418 user@review gerrit review <change>,<patch-set> --label code-review=+1'

fails with:

 fatal: Illegal label name "code-review="

Fixed by using right parse function.

Bug: Issue 2516
Change-Id: Ib95b377786d89bcc33bf0af6ab7e130084547125
This commit is contained in:
Bruce Zu 2014-03-06 13:02:17 +08:00 committed by David Pursehouse
parent 88820201e8
commit d309b5d1d0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java
View File

@ -115,7 +115,7 @@ public class ReviewCommand extends SshCommand {
@Option(name = "--label", aliases = "-l", usage = "custom label(s) to assign", metaVar = "LABEL=VALUE") @Option(name = "--label", aliases = "-l", usage = "custom label(s) to assign", metaVar = "LABEL=VALUE")
void addLabel(final String token) { void addLabel(final String token) {
LabelVote v = LabelVote.parse(token); LabelVote v = LabelVote.parseWithEquals(token);
LabelType.checkName(v.getLabel()); // Disallow SUBM. LabelType.checkName(v.getLabel()); // Disallow SUBM.
customLabels.put(v.getLabel(), v.getValue()); customLabels.put(v.getLabel(), v.getValue());
} }