opendev/gerrit
Code Issues Proposed changes

PatchSetUtil: Remove static modifier from setGroups method

Browse Source 
The method is only called on instances of PatchSetUtil, and does not
reference any static members, so does not need to be static.

Change-Id: Idc3b96569dc07ad9d93956043dff18d51eb7207e
This commit is contained in:
David Pursehouse
2018-08-01 17:46:26 +02:00
parent 698ed331fe
commit d316c355d7
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/com/google/gerrit/server/PatchSetUtil.java
View File

@@ -173,7 +173,7 @@ public class PatchSetUtil {
} }
} }
public static void setGroups(ReviewDb db, ChangeUpdate update, PatchSet ps, List<String> groups) public void setGroups(ReviewDb db, ChangeUpdate update, PatchSet ps, List<String> groups)
throws OrmException { throws OrmException {
ps.setGroups(groups); ps.setGroups(groups);
update.setGroups(groups); update.setGroups(groups);