opendev/gerrit
Code Issues Proposed changes

Support inheritable project specific plugin parameters in the UI

Browse Source 
The UI now also displays the inherited value.

Change-Id: I2ec034f919f31afc5687f9da6cbbe05f878d98c1
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2013-11-28 20:36:33 +01:00
parent 20f256fb89
commit d32beef525
11 changed files with 155 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
gerrit-server/src/main/java/com/google/gerrit/server/config/ProjectConfigEntry.java
View File

@@ -28,33 +28,61 @@ public class ProjectConfigEntry {
}
private final String displayName;
private final boolean inheritable;
private final String defaultValue;
private final Type type;
private final List<String> permittedValues;
public ProjectConfigEntry(String displayName, String defaultValue) {
this(displayName, defaultValue, Type.STRING, null);
this(displayName, defaultValue, false);
}
public ProjectConfigEntry(String displayName, String defaultValue,
boolean inheritable) {
this(displayName, defaultValue, Type.STRING, null, inheritable);
}
public ProjectConfigEntry(String displayName, int defaultValue) {
this(displayName, Integer.toString(defaultValue), Type.INT, null);
this(displayName, defaultValue, false);
}
public ProjectConfigEntry(String displayName, int defaultValue,
boolean inheritable) {
this(displayName, Integer.toString(defaultValue), Type.INT, null,
inheritable);
}
public ProjectConfigEntry(String displayName, long defaultValue) {
this(displayName, Long.toString(defaultValue), Type.LONG, null);
this(displayName, defaultValue, false);
}
public ProjectConfigEntry(String displayName, long defaultValue,
boolean inheritable) {
this(displayName, Long.toString(defaultValue), Type.LONG, null, inheritable);
}
// For inheritable boolean use 'LIST' type with InheritableBoolean
public ProjectConfigEntry(String displayName, boolean defaultValue) {
this(displayName, Boolean.toString(defaultValue), Type.BOOLEAN, null);
this(displayName, Boolean.toString(defaultValue), Type.BOOLEAN, null, false);
}
public ProjectConfigEntry(String displayName, String defaultValue,
List<String> permittedValues) {
this(displayName, defaultValue, Type.LIST, permittedValues);
this(displayName, defaultValue, permittedValues, false);
}
public ProjectConfigEntry(String displayName, String defaultValue,
List<String> permittedValues, boolean inheritable) {
this(displayName, defaultValue, Type.LIST, permittedValues, inheritable);
}
public <T extends Enum<?>> ProjectConfigEntry(String displayName,
T defaultValue, Class<T> permittedValues) {
this(displayName, defaultValue, permittedValues, false);
}
public <T extends Enum<?>> ProjectConfigEntry(String displayName,
T defaultValue, Class<T> permittedValues, boolean inheritable) {
this(displayName, defaultValue.name(), Type.LIST, Lists.transform(
Arrays.asList(permittedValues.getEnumConstants()),
new Function<Enum<?>, String>() {
@@ -62,21 +90,26 @@ public class ProjectConfigEntry {
public String apply(Enum<?> e) {
return e.name();
}
}));
}), inheritable);
}
private ProjectConfigEntry(String displayName, String defaultValue,
Type type, List<String> permittedValues) {
Type type, List<String> permittedValues, boolean inheritable) {
this.displayName = displayName;
this.defaultValue = defaultValue;
this.type = type;
this.permittedValues = permittedValues;
this.inheritable = inheritable;
}
public String getDisplayName() {
return displayName;
}
public boolean isInheritable() {
return inheritable;
}
public String getDefaultValue() {
return defaultValue;
}