opendev/gerrit
Code Issues Proposed changes

Merge branch 'stable-2.10'

Browse Source 
* stable-2.10:
  Don't show 'Add Me' button for change owner or existing reviewers
  Clarify behaviour of the 'Remove Reviewer' permission for change owners
  Include all command arguments in SSH log entry
  Honor expireAfterWrite in the H2CacheImpl
  ACL: Fix transitions check & a '1' in RefName
  Fix exception when clicking on binary file without being signed in
  Use current time for cherry picked commits
  Enable scrollbars for "Edit Commit Message" TextArea
  Only create All-Projects ACL once
  Fix inconsistent behaviour when adding reviewers

Conflicts:
	gerrit-cache-h2/src/main/java/com/google/gerrit/server/cache/h2/H2CacheFactory.java
	gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Reviewers.java
	gerrit-server/src/main/java/com/google/gerrit/server/change/PostReviewers.java

Change-Id: I120ce5cc0ac117673c36d96cad301c4ac0982915
This commit is contained in:
David Pursehouse
2014-12-05 11:19:22 +09:00
parent 3544753b14 074fd761bf
commit d3d7e26235
5 changed files with 34 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Documentation/access-control.txt
View File

@@ -741,9 +741,11 @@ patch set.
This category permits users to remove other users from the list of
reviewers on a change.
The change owner, project owner and site administrator can always
remove reviewers (even without having the `Remove Reviewer` access
right assigned).
Change owners can always remove reviewers who have given a zero or positive
score (even without having the `Remove Reviewer` access right assigned).
Project owners and site administrators can always remove any reviewer (even
without having the `Remove Reviewer` access right assigned).
Users without this access right can only remove themselves from the
reviewer list on a change.