opendev/gerrit
Code Issues Proposed changes

Fix exception when clicking on binary file without being signed in

Browse Source 
The user preferences are only available if the user is signed in.

Change-Id: I2ec307d34464394cd902218a32de1afdf5314f86
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2014-11-03 10:58:02 +01:00
parent 79bb12456d
commit d47148a016
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchTable.java
View File

@@ -267,8 +267,9 @@ public class PatchTable extends Composite {
final PatchScreen.Type screenType) {
if (Dispatcher.isChangeScreen2()) {
return (patch.getPatchType().equals(PatchType.BINARY)
|| Gerrit.getUserAccount().getGeneralPreferences().getDiffView()
.equals(DiffView.UNIFIED_DIFF));
|| (Gerrit.isSignedIn()
&& Gerrit.getUserAccount().getGeneralPreferences().getDiffView()
.equals(DiffView.UNIFIED_DIFF)));
}
return screenType == PatchScreen.Type.UNIFIED;
}