diff --git a/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.html b/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.html index 9085971aa5..545d1702a6 100644 --- a/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.html +++ b/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.html @@ -28,21 +28,32 @@ limitations under the License. :host { background-color: var(--dialog-background-color); display: block; - padding: 1em; } - header { + section { display: flex; + padding: .5em 1.5em; } - footer { + section:not(:first-of-type) { + border-top: 1px solid var(--border-color); + } + .flexContainer { display: flex; justify-content: space-between; padding-top: .75em; } + .footer { + justify-content: flex-end; + } .closeButtonContainer { + align-items: flex-end; display: flex; flex: 0; justify-content: flex-end; } + .patchFiles, + .archivesContainer { + padding-bottom: .5em; + } .patchFiles { margin-right: 2em; } @@ -56,26 +67,26 @@ limitations under the License. margin-right: 0; } .title { - text-align: center; flex: 1; + font-family: var(--font-family-bold); + } + .hidden { + display: none; } -
+
Patch set [[patchNum]] of [[_computePatchSetQuantity(change.revisions)]] - - Close - -
- +
+ -
+
+
@@ -104,7 +115,14 @@ limitations under the License.
- +
+ diff --git a/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.js b/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.js index fa3e5c9809..20449b0471 100644 --- a/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.js @@ -172,5 +172,9 @@ this._selectedScheme = schemes.sort()[0]; } }, + + _computeShowDownloadCommands(schemes) { + return schemes.length ? '' : 'hidden'; + }, }); })(); diff --git a/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog_test.html b/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog_test.html index 84fe8a9cba..19932c58dd 100644 --- a/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog_test.html +++ b/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog_test.html @@ -183,5 +183,10 @@ limitations under the License. MockInteractions.tap(element.$$('.closeButtonContainer gr-button')); }); }); + + test('_computeShowDownloadCommands', () => { + assert.equal(element._computeShowDownloadCommands([]), 'hidden'); + assert.equal(element._computeShowDownloadCommands(['test']), ''); + }); }); diff --git a/polygerrit-ui/app/elements/shared/gr-download-commands/gr-download-commands.html b/polygerrit-ui/app/elements/shared/gr-download-commands/gr-download-commands.html index 7570533017..440a6e3a7f 100644 --- a/polygerrit-ui/app/elements/shared/gr-download-commands/gr-download-commands.html +++ b/polygerrit-ui/app/elements/shared/gr-download-commands/gr-download-commands.html @@ -55,8 +55,6 @@ limitations under the License. .commands { display: flex; flex-direction: column; - border-bottom: 1px solid var(--border-color); - border-top: 1px solid var(--border-color); padding: .5em; } gr-copy-clipboard {