diff --git a/BUILD b/BUILD index d924417c08..318968d23e 100644 --- a/BUILD +++ b/BUILD @@ -57,7 +57,6 @@ genrule( cmd = ("cat bazel-out/volatile-status.txt bazel-out/stable-status.txt | " + "grep STABLE_BUILD_GERRIT_LABEL | cut -d ' ' -f 2 > $@"), stamp = 1, - visibility = ["//visibility:public"], ) genrule( @@ -65,7 +64,6 @@ genrule( srcs = ["//Documentation:licenses.txt"], outs = ["LICENSES.txt"], cmd = "cp $< $@", - visibility = ["//visibility:public"], ) pkg_war( diff --git a/Documentation/BUILD b/Documentation/BUILD index 4177f5101d..6fa598376a 100644 --- a/Documentation/BUILD +++ b/Documentation/BUILD @@ -40,7 +40,6 @@ filegroup( ":prettify_files", "//:LICENSES.txt", ], - visibility = ["//visibility:public"], ) license_map( @@ -51,7 +50,6 @@ license_map( "//polygerrit-ui/app:polygerrit_ui", "//java/com/google/gerrit/pgm", ], - visibility = ["//visibility:public"], ) license_map( @@ -60,7 +58,6 @@ license_map( "//gerrit-gwtui:ui_module", "//polygerrit-ui/app:polygerrit_ui", ], - visibility = ["//visibility:public"], ) DOC_DIR = "Documentation" @@ -88,7 +85,6 @@ genasciidoc( srcs = SRCS, attributes = documentation_attributes(), backend = "html5", - visibility = ["//visibility:public"], ) genasciidoc_zip( @@ -97,7 +93,6 @@ genasciidoc_zip( attributes = documentation_attributes(), backend = "html5", directory = DOC_DIR, - visibility = ["//visibility:public"], ) genasciidoc_zip( @@ -107,5 +102,4 @@ genasciidoc_zip( backend = "html5", directory = DOC_DIR, searchbox = False, - visibility = ["//visibility:public"], ) diff --git a/Documentation/config-plugins.txt b/Documentation/config-plugins.txt index b9c51722ba..6d4fe3eb2f 100644 --- a/Documentation/config-plugins.txt +++ b/Documentation/config-plugins.txt @@ -112,16 +112,6 @@ Project] | link:https://gerrit.googlesource.com/plugins/reviewnotes/+doc/master/src/main/resources/Documentation/about.md[ Documentation] -[[review-strategy]] -=== review-strategy - -This plugin allows users to configure different review strategies. - -link:https://gerrit-review.googlesource.com/admin/repos/plugins/review-strategy[ -Project] | -link:https://gerrit.googlesource.com/plugins/review-strategy/+doc/master/src/main/resources/Documentation/about.md[ -Documentation] - [[singleusergroup]] === singleusergroup @@ -565,6 +555,16 @@ Documentation] | link:https://gerrit.googlesource.com/plugins/reparent/+doc/master/src/main/resources/Documentation/config.md[ Configuration] +[[review-strategy]] +=== review-strategy + +This plugin allows users to configure different review strategies. + +link:https://gerrit-review.googlesource.com/admin/repos/plugins/review-strategy[ +Project] | +link:https://gerrit.googlesource.com/plugins/review-strategy/+doc/master/src/main/resources/Documentation/about.md[ +Documentation] + [[reviewers]] === reviewers diff --git a/lib/commons/BUILD b/lib/commons/BUILD index bb36389846..93d3c2f877 100644 --- a/lib/commons/BUILD +++ b/lib/commons/BUILD @@ -3,21 +3,18 @@ package(default_visibility = ["//visibility:public"]) java_library( name = "codec", data = ["//lib:LICENSE-Apache2.0"], - visibility = ["//visibility:public"], exports = ["@commons-codec//jar"], ) java_library( name = "compress", data = ["//lib:LICENSE-Apache2.0"], - visibility = ["//visibility:public"], exports = ["@commons-compress//jar"], ) java_library( name = "lang", data = ["//lib:LICENSE-Apache2.0"], - visibility = ["//visibility:public"], exports = ["@commons-lang//jar"], ) @@ -30,14 +27,12 @@ java_library( java_library( name = "net", data = ["//lib:LICENSE-Apache2.0"], - visibility = ["//visibility:public"], exports = ["@commons-net//jar"], ) java_library( name = "dbcp", data = ["//lib:LICENSE-Apache2.0"], - visibility = ["//visibility:public"], exports = ["@commons-dbcp//jar"], runtime_deps = [":pool"], ) @@ -45,20 +40,17 @@ java_library( java_library( name = "pool", data = ["//lib:LICENSE-Apache2.0"], - visibility = ["//visibility:public"], exports = ["@commons-pool//jar"], ) java_library( name = "validator", data = ["//lib:LICENSE-Apache2.0"], - visibility = ["//visibility:public"], exports = ["@commons-validator//jar"], ) java_library( name = "io", data = ["//lib:LICENSE-Apache2.0"], - visibility = ["//visibility:public"], exports = ["@commons-io//jar"], ) diff --git a/lib/elasticsearch-rest-client/BUILD b/lib/elasticsearch-rest-client/BUILD index c6357d083e..8df3c704ef 100644 --- a/lib/elasticsearch-rest-client/BUILD +++ b/lib/elasticsearch-rest-client/BUILD @@ -3,6 +3,5 @@ package(default_visibility = ["//visibility:public"]) java_library( name = "elasticsearch-rest-client", data = ["//lib:LICENSE-elasticsearch"], - visibility = ["//visibility:public"], exports = ["@elasticsearch-rest-client//jar"], ) diff --git a/lib/greenmail/BUILD b/lib/greenmail/BUILD index 55eb9f38a4..41fbdab1e5 100644 --- a/lib/greenmail/BUILD +++ b/lib/greenmail/BUILD @@ -3,6 +3,5 @@ package(default_visibility = ["//visibility:public"]) java_library( name = "greenmail", data = ["//lib:LICENSE-Apache2.0"], - visibility = ["//visibility:public"], exports = ["@greenmail//jar"], ) diff --git a/lib/httpcomponents/BUILD b/lib/httpcomponents/BUILD index 74cca14a7e..03d9b68e2b 100644 --- a/lib/httpcomponents/BUILD +++ b/lib/httpcomponents/BUILD @@ -3,7 +3,6 @@ package(default_visibility = ["//visibility:public"]) java_library( name = "fluent-hc", data = ["//lib:LICENSE-Apache2.0"], - visibility = ["//visibility:public"], exports = ["@fluent-hc//jar"], runtime_deps = [":httpclient"], ) @@ -11,7 +10,6 @@ java_library( java_library( name = "httpclient", data = ["//lib:LICENSE-Apache2.0"], - visibility = ["//visibility:public"], exports = ["@httpclient//jar"], runtime_deps = [ ":httpcore", @@ -23,7 +21,6 @@ java_library( java_library( name = "httpcore", data = ["//lib:LICENSE-Apache2.0"], - visibility = ["//visibility:public"], exports = ["@httpcore//jar"], ) diff --git a/lib/jackson/BUILD b/lib/jackson/BUILD index 3d751abb59..0034748d28 100644 --- a/lib/jackson/BUILD +++ b/lib/jackson/BUILD @@ -1,5 +1,3 @@ -package(default_visibility = ["//visibility:public"]) - java_library( name = "jackson-core", data = ["//lib:LICENSE-Apache2.0"], diff --git a/lib/lucene/BUILD b/lib/lucene/BUILD index 421caed03d..eab2ac8266 100644 --- a/lib/lucene/BUILD +++ b/lib/lucene/BUILD @@ -11,13 +11,11 @@ merge_maven_jars( "@lucene-core//jar", ], data = ["//lib:LICENSE-Apache2.0"], - visibility = ["//visibility:public"], ) java_library( name = "lucene-analyzers-common", data = ["//lib:LICENSE-Apache2.0"], - visibility = ["//visibility:public"], exports = ["@lucene-analyzers-common//jar"], runtime_deps = [":lucene-core-and-backward-codecs"], ) @@ -25,14 +23,12 @@ java_library( java_library( name = "lucene-core", data = ["//lib:LICENSE-Apache2.0"], - visibility = ["//visibility:public"], exports = ["@lucene-core//jar"], ) java_library( name = "lucene-misc", data = ["//lib:LICENSE-Apache2.0"], - visibility = ["//visibility:public"], exports = ["@lucene-misc//jar"], runtime_deps = [":lucene-core-and-backward-codecs"], ) @@ -40,7 +36,6 @@ java_library( java_library( name = "lucene-queryparser", data = ["//lib:LICENSE-Apache2.0"], - visibility = ["//visibility:public"], exports = ["@lucene-queryparser//jar"], runtime_deps = [":lucene-core-and-backward-codecs"], ) diff --git a/lib/polymer_externs/BUILD b/lib/polymer_externs/BUILD index 2f1bdbded2..cd71d64392 100644 --- a/lib/polymer_externs/BUILD +++ b/lib/polymer_externs/BUILD @@ -12,9 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -package( - default_visibility = ["//visibility:public"], -) +package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_closure//closure:defs.bzl", "closure_js_library") diff --git a/polygerrit-ui/BUILD b/polygerrit-ui/BUILD index 384f835f4a..5889ffd50c 100644 --- a/polygerrit-ui/BUILD +++ b/polygerrit-ui/BUILD @@ -1,6 +1,4 @@ -package( - default_visibility = ["//visibility:public"], -) +package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_go//go:def.bzl", "go_binary") load("//tools/bzl:js.bzl", "bower_component_bundle") @@ -51,7 +49,6 @@ genrule2( "zip -qr $$ROOT/$@ fonts", ]), output_to_bindir = 1, - visibility = ["//visibility:public"], ) go_binary( diff --git a/polygerrit-ui/app/BUILD b/polygerrit-ui/app/BUILD index c7357462e2..0aa70b87b3 100644 --- a/polygerrit-ui/app/BUILD +++ b/polygerrit-ui/app/BUILD @@ -1,6 +1,4 @@ -package( - default_visibility = ["//visibility:public"], -) +package(default_visibility = ["//visibility:public"]) load(":rules.bzl", "polygerrit_bundle") load("//tools/bzl:genrule2.bzl", "genrule2")