opendev/gerrit
Code Issues Proposed changes

Fix raw type warnings

Browse Source 
References to generic types should be parameterized.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: If99240034ad84412eb12aa1e1ca9152c948a2815
This commit is contained in:
Edwin Kempin
2020-07-29 13:05:45 +02:00
parent 1be45526a7
commit d5203cc63d
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/com/google/gerrit/server/restapi/change/ReplyAttentionSetUpdates.java
View File

@@ -80,7 +80,7 @@ public class ReplyAttentionSetUpdates {
throws IOException, ConfigInvalidException, PermissionBackendException,
UnprocessableEntityException {
Set<Account.Id> potentiallyRemovedReviewerIds = new HashSet();
Set<Account.Id> potentiallyRemovedReviewerIds = new HashSet<>();
for (String reviewer : potentiallyRemovedReviewers) {
potentiallyRemovedReviewerIds.add(getAccountId(changeNotes, reviewer));
}

5
java/gerrit/PRED_files_1.java
View File

@@ -55,7 +55,8 @@ public class PRED_files_1 extends Predicate.P1 {
try (RevWalk revWalk = new RevWalk(StoredValues.REPOSITORY.get(engine))) {
RevCommit commit = revWalk.parseCommit(StoredValues.getPatchSet(engine).commitId());
List<PatchListEntry> patches = StoredValues.PATCH_LIST.get(engine).getPatches();
Set submodules = getAllSubmodulePaths(StoredValues.REPOSITORY.get(engine), commit, patches);
Set<String> submodules =
getAllSubmodulePaths(StoredValues.REPOSITORY.get(engine), commit, patches);
for (PatchListEntry entry : patches) {
if (Patch.isMagic(entry.getNewName())) {
continue;
@@ -84,7 +85,7 @@ public class PRED_files_1 extends Predicate.P1 {
private static Set<String> getAllSubmodulePaths(
Repository repository, RevCommit commit, List<PatchListEntry> patches)
throws PrologException, IOException {
Set<String> submodules = new HashSet();
Set<String> submodules = new HashSet<>();
try (TreeWalk treeWalk = new TreeWalk(repository)) {
treeWalk.addTree(commit.getTree());
Set<String> allPaths =