opendev/gerrit
Code Issues Proposed changes

Place change status right after change number instead of title

Browse Source 
Instead of having it be grayed out, place it right next to the
change number before the colon.

Bug: Issue 4540
Change-Id: I7ff90183c4376bea0ecd76b7f853a5ef8ea1af61
This commit is contained in:
Andrew Bonventre
2016-11-01 15:03:41 -07:00
parent e54913e24a
commit d5aa2ff544
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html
View File

@@ -77,7 +77,6 @@ limitations under the License.
width: 50em;
}
.changeStatus {
color: #999;
text-transform: capitalize;
}
/* Strong specificity here is needed due to
@@ -212,9 +211,10 @@ limitations under the License.
<div class="header">
<span class="header-title">
<gr-change-star change="{{_change}}" hidden$="[[!_loggedIn]]"></gr-change-star>
<a href$="[[_computeChangePermalink(_change._number)]]">[[_change._number]]</a><span>:</span>
<a href$="[[_computeChangePermalink(_change._number)]]">[[_change._number]]</a><!--
--><span class="changeStatus">[[_computeChangeStatus(_change, _patchRange.patchNum)]]</span><!--
--><span>:</span>
<span>[[_change.subject]]</span>
<span class="changeStatus">[[_computeChangeStatus(_change, _patchRange.patchNum)]]</span>
</span>
</div>
<section class="changeInfo">

2
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js
View File

@@ -495,7 +495,7 @@
} else {
statusString = this.changeStatusString(change);
}
return statusString ? '(' + statusString + ')' : '';
return statusString ? ' (' + statusString + ')' : '';
},
_computeLatestPatchNum: function(allPatchSets) {

4
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.html
View File

@@ -415,7 +415,7 @@ limitations under the License.
labels: {},
};
var status = element._computeChangeStatus(element._change, '1');
assert.equal(status, '(Draft)');
assert.equal(status, ' (Draft)');
});
test('revision status draft', function() {
@@ -438,7 +438,7 @@ limitations under the License.
labels: {},
};
var status = element._computeChangeStatus(element._change, '2');
assert.equal(status, '(Draft)');
assert.equal(status, ' (Draft)');
});
test('show commit message edit button', function() {