opendev
/
gerrit
Code Issues Proposed changes

Default to writing comments in JSON format 

The default in 2.15-rc2 and earlier was inadvertently left to use the
legacy comment format. Combined with the fact that NoteDb is the default
for changes in 2.15-rc2, this means that there may be sites in the wild
that have notes written in the legacy format.

Ultimately, we will want to migrate those sites to use the JSON format,
so we can delete the legacy codepaths. However, we can't do schema
migrations in a stable branch, so the legacy code will have to live on
for another release cycle. The alternative would be to provide a standalone
migration tool in the stable branch, but that puts an additional burden
on site admins, and doesn't provide any real benefit other than allowing
us to delete some code sooner.

All that being said, it still makes sense to change the default in the
stable branch, if for no other reason than to minimize the time spent in
migrating data on the next upgrade.

Change-Id: I0a1116317fa5740e49548eb2349d14a5bb7e83e1
This commit is contained in:
Dave Borowitz 2017-12-11 15:32:15 -05:00
parent 045f2a3339
commit d5cefcd213
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/notedb/ChangeNoteUtil.java
View File

@ -131,7 +131,7 @@ public class ChangeNoteUtil {
this.serverIdent = serverIdent;
this.anonymousCowardName = anonymousCowardName;
this.serverId = serverId;
this.writeJson = config.getBoolean("notedb", "writeJson", false);
this.writeJson = config.getBoolean("notedb", "writeJson", true);
}
@VisibleForTesting