opendev/gerrit
Code Issues Proposed changes

Merge "ChangeEmail: Don't log a warning for valid reviewer fields that are ignored"

Browse Source
This commit is contained in:
Alice Kober-Sotzek
2018-02-16 10:24:39 +00:00
committed by Gerrit Code Review
parent 81a5a5d178 18a7e3c194
commit d5f63d6f36
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
java/com/google/gerrit/server/index/change/ChangeField.java
View File

@@ -269,7 +269,12 @@ public class ChangeField {
int i2 = v.lastIndexOf(',');
if (i2 == i) {
log.warn("Invalid value for reviewer field from change {}: {}", changeId.get(), v);
// Don't log a warning here.
// For each reviewer we store 2 values in the reviewer field, one value with the format
// "<reviewer-type>,<account-id>" and one value with the format
// "<reviewer-type>,<account-id>,<timestamp>" (see #getReviewerFieldValues(ReviewerSet)).
// For parsing we are only interested in the "<reviewer-type>,<account-id>,<timestamp>"
// value and the "<reviewer-type>,<account-id>" value is ignored here.
continue;
}
@@ -315,7 +320,13 @@ public class ChangeField {
int i2 = v.lastIndexOf(',');
if (i2 == i) {
log.warn("Invalid value for reviewer by email field from change {}: {}", changeId.get(), v);
// Don't log a warning here.
// For each reviewer we store 2 values in the reviewer field, one value with the format
// "<reviewer-type>,<email>" and one value with the format
// "<reviewer-type>,<email>,<timestamp>" (see
// #getReviewerByEmailFieldValues(ReviewerByEmailSet)).
// For parsing we are only interested in the "<reviewer-type>,<email>,<timestamp>" value
// and the "<reviewer-type>,<email>" value is ignored here.
continue;
}