opendev
/
gerrit
Code Issues Proposed changes

Allow plugins to use self-provided licenses for used Maven Jars 

maven_jar only allowed to use licenses that were defined in
'//lib:'. But plugins may need further licenses that are not yet in
core (E.g.: plugins/its-jira relies on a jar with CPL1.0
license). Since, plugins cannot add rules underneath '//lib:', we add
the local_license parameter to maven_jar, which allows plugins to use
licenses from ':' instead of '//lib:'.

Change-Id: Icc40c413eed65a0b6e3003021050d91086ca4c34
This commit is contained in:
Christian Aistleitner 2014-09-10 11:02:59 +02:00 committed by David Ostrovsky
parent 24ec75ea2f
commit d60c833114
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/maven.defs
View File

@ -40,7 +40,8 @@ def maven_jar(
sha1 = '', bin_sha1 = '', src_sha1 = '',
repository = MAVEN_CENTRAL,
attach_source = True,
visibility = ['PUBLIC']):
visibility = ['PUBLIC'],
local_license = False):
from os import path
parts = id.split(':')
@ -89,7 +90,10 @@ def maven_jar(
cmd = ' '.join(cmd),
out = binjar,
)
license = ['//lib:LICENSE-' + license]
license = ':LICENSE-' + license
if not local_license:
license = '//lib' + license
license = [license]
if src_sha1 or attach_source:
cmd = ['$(exe //tools:download_file)', '-o', '$OUT', '-u', srcurl]