From d632d68c64be6c470c704e60fdce073f2a8dd350 Mon Sep 17 00:00:00 2001 From: David Ostrovsky Date: Tue, 15 Oct 2019 00:07:44 +0200 Subject: [PATCH] Remove mention of container.javaOptions for newer Java versions Change-Id: Ieb3b6db22633155f3e0ecbb550aa53c8d090f184 --- Documentation/dev-bazel.txt | 16 ---------------- Documentation/dev-eclipse.txt | 5 ----- tools/bzl/junit.bzl | 1 - 3 files changed, 22 deletions(-) diff --git a/Documentation/dev-bazel.txt b/Documentation/dev-bazel.txt index ecee622ad7..e973924839 100644 --- a/Documentation/dev-bazel.txt +++ b/Documentation/dev-bazel.txt @@ -78,14 +78,6 @@ $ cat << EOF > ~/.bazelrc Now, invoking Bazel with just `bazel build :release` would include all those options. -Note that the follow option must be added to `container.javaOptions` -in `$gerrit_site/etc/gerrit.config` to run Gerrit with Java 12: - -``` -[container] - javaOptions = --add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED -``` - [[java-11]] ==== Java 11 support @@ -102,14 +94,6 @@ To build Gerrit with Java 11, specify JDK 11 java toolchain: :release ``` -Note that the follow option must be added to `container.javaOptions` -in `$gerrit_site/etc/gerrit.config` to run Gerrit with Java 11: - -``` -[container] - javaOptions = --add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED -``` - === Node.js and npm packages See link:https://gerrit.googlesource.com/gerrit/+/master/polygerrit-ui/README.md#installing-node_js-and-npm-packages[Installing Node.js and npm packages]. diff --git a/Documentation/dev-eclipse.txt b/Documentation/dev-eclipse.txt index 67ced54eae..f113a160ba 100644 --- a/Documentation/dev-eclipse.txt +++ b/Documentation/dev-eclipse.txt @@ -55,11 +55,6 @@ Java 8 is still the default: * Add JRE, e.g.: directory: /usr/lib64/jvm/java-9-openjdk, name: java-9-openjdk-9 * Change execution environemnt for gerrit project to: JavaSE-9 (java-9-openjdk-9) * Check that compiler compliance level in gerrit project is set to: 9 -* Add this parameter to VM argument for gerrit_daemin launcher: ----- - --add-modules java.activation \ - --add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED ----- [[Formatting]] == Code Formatter Settings diff --git a/tools/bzl/junit.bzl b/tools/bzl/junit.bzl index 987c5cae91..66d72303c1 100644 --- a/tools/bzl/junit.bzl +++ b/tools/bzl/junit.bzl @@ -70,7 +70,6 @@ POST_JDK8_OPTS = [ # Enforce JDK 8 compatibility on Java 9, see # https://docs.oracle.com/javase/9/intl/internationalization-enhancements-jdk-9.htm#JSINT-GUID-AF5AECA7-07C1-4E7D-BC10-BC7E73DC6C7F "-Djava.locale.providers=COMPAT,CLDR,SPI", - "--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED", ] def junit_tests(name, srcs, **kwargs):